Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2370273003: Drop dispatch_release(): ARC manages dispatch queues with a deployment target >= 10.8 (Closed)

Created:
4 years, 2 months ago by Sidney San Martín
Modified:
4 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop dispatch_release(): ARC manages dispatch queues with a deployment target >= 10.8 Note: this is a leak with our current deployment target (but not a big deal for the short-lived installer). BUG=650807 Committed: https://crrev.com/0e482836bff9bb98a972cbc3c2651669d69e7254 Cr-Commit-Position: refs/heads/master@{#421345}

Patch Set 1 #

Patch Set 2 : Back... with a guard! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/installer/mac/app/Unpacker.m View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sidney San Martín
4 years, 2 months ago (2016-09-27 21:16:58 UTC) #3
Mark Mentovai
For hygiene, #if per the suggestion in https://crbug.com/650807?
4 years, 2 months ago (2016-09-27 21:17:54 UTC) #4
Sidney San Martín
#if'd and tested with both deployment targets.
4 years, 2 months ago (2016-09-27 21:27:50 UTC) #5
Mark Mentovai
LGTM
4 years, 2 months ago (2016-09-27 21:34:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370273003/20001
4 years, 2 months ago (2016-09-27 21:34:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 21:45:47 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 21:47:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e482836bff9bb98a972cbc3c2651669d69e7254
Cr-Commit-Position: refs/heads/master@{#421345}

Powered by Google App Engine
This is Rietveld 408576698