chrome/installer/mac/app/Unpacker.m - Issue 2370273003: Drop dispatch_release(): ARC manages dispatch queues with a deployment target >= 10.8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mac/app/Unpacker.m

Issue 2370273003: Drop dispatch_release(): ARC manages dispatch queues with a deployment target >= 10.8 (Closed)

Patch Set: Back... with a guard! Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/mac/app/Unpacker.m

diff --git a/chrome/installer/mac/app/Unpacker.m b/chrome/installer/mac/app/Unpacker.m

index 5d16bffdac6dc381b8e078406db699f427b61e55..02ff0121362d1c0598ae3a8e66eff75b44c17d16 100644

--- a/chrome/installer/mac/app/Unpacker.m

+++ b/chrome/installer/mac/app/Unpacker.m

@@ -146,7 +146,9 @@ static void unmount_callback(DADiskRef disk,

- (void)didFinishEjectingDisk:(DADiskRef)disk

withDissenter:(DADissenterRef)dissenter {

DASessionSetDispatchQueue(session_, NULL);

+#if MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_8

dispatch_release(unpack_dq_);

+#endif

CFRelease(session_);

NSError* error = nil;

if (dissenter) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »