Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2370273002:
deleted three UseCounter items to fix issue 645909 (Closed)
Descriptiondeleted UseCounter usages (InvalidFrameAncestorsDirectiveInMetaCSP, InvalidSandboxDirectiveInMetaCSP, CSPDirectiveList) from UseCounter header file and also removed associated calls to fix issue 645909
BUG=645909
Committed: https://crrev.com/b0a3a3721a46a6d003f114622c5d1b590f037fb7
Cr-Commit-Position: refs/heads/master@{#421818}
Patch Set 1 #
Total comments: 1
Patch Set 2 : implemented asvitkine@ suggestion to keep histogram entries for compatibility purpose #
Messages
Total messages: 25 (16 generated)
Description was changed from ========== deleted UseCounter usages in order to fix issue 645909 BUG=645909 ========== to ========== deleted UseCounter usages in order to fix issue 645909 BUG=645909 ==========
dherkel@google.com changed reviewers: + mkwst@chromium.org
The CQ bit was checked by dherkel@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hi mike! Please review this. Kind regards, Dominik
Description was changed from ========== deleted UseCounter usages in order to fix issue 645909 BUG=645909 ========== to ========== deleted UseCounter usages (InvalidFrameAncestorsDirectiveInMetaCSP, InvalidSandboxDirectiveInMetaCSP, CSPDirectiveList) from UseCounter header file and also removed associated calls and histogram entries to fix issue 645909 BUG=645909 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Exceeded global retry quota
LGTM!
(Hit the "commit" button when you're ready to land this.)
asvitkine@chromium.org changed reviewers: + asvitkine@chromium.org
https://codereview.chromium.org/2370273002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2370273002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:81860: - <int value="1281" label="InvalidReportUriDirectiveInMetaCSP"/> Entries shouldn't be deleted from histograms.xml as it's used to view data from old versions. Just leave these here.
The CQ bit was checked by dherkel@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== deleted UseCounter usages (InvalidFrameAncestorsDirectiveInMetaCSP, InvalidSandboxDirectiveInMetaCSP, CSPDirectiveList) from UseCounter header file and also removed associated calls and histogram entries to fix issue 645909 BUG=645909 ========== to ========== deleted UseCounter usages (InvalidFrameAncestorsDirectiveInMetaCSP, InvalidSandboxDirectiveInMetaCSP, CSPDirectiveList) from UseCounter header file and also removed associated calls to fix issue 645909 BUG=645909 ==========
Hi! I applied asvitkine@'s suggested change. Please look into it. Kind regards, Dominik
lgtm
The CQ bit was checked by dherkel@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org Link to the patchset: https://codereview.chromium.org/2370273002/#ps20001 (title: "implemented asvitkine@ suggestion to keep histogram entries for compatibility purpose")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== deleted UseCounter usages (InvalidFrameAncestorsDirectiveInMetaCSP, InvalidSandboxDirectiveInMetaCSP, CSPDirectiveList) from UseCounter header file and also removed associated calls to fix issue 645909 BUG=645909 ========== to ========== deleted UseCounter usages (InvalidFrameAncestorsDirectiveInMetaCSP, InvalidSandboxDirectiveInMetaCSP, CSPDirectiveList) from UseCounter header file and also removed associated calls to fix issue 645909 BUG=645909 Committed: https://crrev.com/b0a3a3721a46a6d003f114622c5d1b590f037fb7 Cr-Commit-Position: refs/heads/master@{#421818} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b0a3a3721a46a6d003f114622c5d1b590f037fb7 Cr-Commit-Position: refs/heads/master@{#421818} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
