Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp

Issue 2370273002: deleted three UseCounter items to fix issue 645909 (Closed)
Patch Set: implemented asvitkine@ suggestion to keep histogram entries for compatibility purpose Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
diff --git a/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp b/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
index dcf86e31c0bdebc1e08714f626546f0f3b353b7a..1270d95b20c3b4c1da962b4f48c732172bcb081b 100644
--- a/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
+++ b/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
@@ -670,7 +670,6 @@ void CSPDirectiveList::parseReportURI(const String& name, const String& value)
// Remove report-uri in meta policies, per https://www.w3.org/TR/CSP2/#delivery-html-meta-element.
if (m_headerSource == ContentSecurityPolicyHeaderSourceMeta) {
- UseCounter::count(m_policy->document(), UseCounter::InvalidReportUriDirectiveInMetaCSP);
m_policy->reportInvalidDirectiveInMeta(name);
return;
}
@@ -705,7 +704,6 @@ void CSPDirectiveList::setCSPDirective(const String& name, const String& value,
// Remove frame-ancestors directives in meta policies, per https://www.w3.org/TR/CSP2/#delivery-html-meta-element.
if (m_headerSource == ContentSecurityPolicyHeaderSourceMeta && name == ContentSecurityPolicy::FrameAncestors) {
- UseCounter::count(m_policy->document(), UseCounter::InvalidFrameAncestorsDirectiveInMetaCSP);
m_policy->reportInvalidDirectiveInMeta(name);
return;
}
@@ -717,7 +715,6 @@ void CSPDirectiveList::applySandboxPolicy(const String& name, const String& sand
{
// Remove sandbox directives in meta policies, per https://www.w3.org/TR/CSP2/#delivery-html-meta-element.
if (m_headerSource == ContentSecurityPolicyHeaderSourceMeta) {
- UseCounter::count(m_policy->document(), UseCounter::InvalidSandboxDirectiveInMetaCSP);
m_policy->reportInvalidDirectiveInMeta(name);
return;
}
@@ -839,8 +836,6 @@ void CSPDirectiveList::parseReferrer(const String& name, const String& value)
{
m_didSetReferrerPolicy = true;
- UseCounter::count(m_policy->document(), UseCounter::CSPReferrerDirective);
-
if (value.isEmpty()) {
m_policy->reportInvalidReferrer(value);
m_referrerPolicy = ReferrerPolicyNever;
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698