Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2370233002: Record clicks on download and overflow buttons in media controls. (Closed)

Created:
4 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 2 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record clicks on download and overflow buttons in media controls. BUG=650592 Committed: https://crrev.com/8aaf4ec7b92cdd68062d49faf8783a5ab139834e Cr-Commit-Position: refs/heads/master@{#421329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 2 chunks +15 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2375633002 Patch 1

Messages

Total messages: 13 (7 generated)
mlamouri (slow - plz ping)
isherman@, PTAL at the actions.xml change zqzhang@, PTAL at the code change
4 years, 2 months ago (2016-09-27 10:41:36 UTC) #4
Zhiqiang Zhang (Slow)
LGTM
4 years, 2 months ago (2016-09-27 10:44:41 UTC) #5
Ilya Sherman
LGTM
4 years, 2 months ago (2016-09-27 20:46:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370233002/1
4 years, 2 months ago (2016-09-27 20:46:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 20:53:44 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 20:56:41 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8aaf4ec7b92cdd68062d49faf8783a5ab139834e
Cr-Commit-Position: refs/heads/master@{#421329}

Powered by Google App Engine
This is Rietveld 408576698