Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2375633002: Close the media controls overflow menu when an item is selected. (Closed)

Created:
4 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Close the media controls overflow menu when an item is selected. BUG=650593 Committed: https://crrev.com/1b8288ae4c0e8369203915162d4a20464c7930e3 Cr-Commit-Position: refs/heads/master@{#421508}

Patch Set 1 #

Patch Set 2 : fix crash #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
A + third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html View 1 chunk +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 6 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
mlamouri (slow - plz ping)
4 years, 2 months ago (2016-09-27 13:06:13 UTC) #4
Zhiqiang Zhang (Slow)
lgtm
4 years, 2 months ago (2016-09-28 10:17:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375633002/40001
4 years, 2 months ago (2016-09-28 12:14:55 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-28 13:31:20 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 13:33:37 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b8288ae4c0e8369203915162d4a20464c7930e3
Cr-Commit-Position: refs/heads/master@{#421508}

Powered by Google App Engine
This is Rietveld 408576698