Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 23702010: Revert 220418 "cc: Block commit on activate by setting a flag on..." (Closed)

Created:
7 years, 3 months ago by danakj
Modified:
7 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 220418 "cc: Block commit on activate by setting a flag on..." http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/14025/steps/cc_unittests/logs/stdio#failure7 > cc: Block commit on activate by setting a flag on LayerTreeHost. > > Currently the ThreadProxy recursively asks all layers in the tree if > they should block the commit. This is problematic as when you remove > a layer from a the tree, it may want to block the commit to get back > resources from its active-tree impl-layer. > > Instead, have layers call SetNextCommitWaitsForActivation() when they > want the next commit to block on activate. This way we only block > commits that matter, not every commit when there's a texture layer > present. And we can allow a layer to block the commit when it is > leaving the tree. > > Tests: > TextureLayerNoMailboxIsActivatedDuringCommit > TextureLayerMailboxIsActivatedDuringCommit > DelegatedFrameIsActivatedDuringCommit > > R=enne, piman > BUG=277953 > > Review URL: https://chromiumcodereview.appspot.com/23530003 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -434 lines) Patch
M trunk/src/cc/layers/delegated_renderer_layer.h View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/cc/layers/delegated_renderer_layer.cc View 3 chunks +8 lines, -20 lines 0 comments Download
M trunk/src/cc/layers/layer.h View 3 chunks +8 lines, -7 lines 0 comments Download
M trunk/src/cc/layers/layer.cc View 4 chunks +24 lines, -13 lines 0 comments Download
M trunk/src/cc/layers/texture_layer.h View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/cc/layers/texture_layer.cc View 4 chunks +9 lines, -16 lines 0 comments Download
M trunk/src/cc/layers/texture_layer_unittest.cc View 2 chunks +0 lines, -237 lines 0 comments Download
M trunk/src/cc/layers/tiled_layer.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/cc/layers/tiled_layer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/cc/test/fake_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest_delegated.cc View 2 chunks +0 lines, -104 lines 0 comments Download
M trunk/src/cc/trees/proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/trees/single_thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/trees/single_thread_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/cc/trees/thread_proxy.h View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/cc/trees/thread_proxy.cc View 5 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danakj
7 years, 3 months ago (2013-08-30 00:42:02 UTC) #1
danakj
7 years, 3 months ago (2013-08-30 00:44:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r220455.

Powered by Google App Engine
This is Rietveld 408576698