Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: media/base/text_track.cc

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: incorporate aaron's comments (10/16) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/text_track.cc
diff --git a/media/base/text_track.cc b/media/base/text_track.cc
new file mode 100644
index 0000000000000000000000000000000000000000..50f3b3f59dd79f7fe599378f7db1fe499459d5b2
--- /dev/null
+++ b/media/base/text_track.cc
@@ -0,0 +1,34 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/base/text_track.h"
+
+namespace media {
+
+TextTrackConfig::TextTrackConfig()
+ : kind_(kTextNone) {
+}
+
+TextTrackConfig::TextTrackConfig(TextKind kind,
+ const std::string& label,
+ const std::string& language)
+ : kind_(kind),
+ label_(label_),
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 nit: s/_// in second label_
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
+ language_(language_) {
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 ditto
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
+}
+
+bool TextTrackConfig::Matches(const TextTrackConfig& config) const {
+ if (config.kind_ != kind_)
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 nit: Merge all this into a single return statement
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
+ return false;
+
+ if (config.label_ != label_)
+ return false;
+
+ if (config.language_ != language_)
+ return false;
+
+ return true;
+}
+
+} // namespace media

Powered by Google App Engine
This is Rietveld 408576698