Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Side by Side Diff: media/base/text_track.cc

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: incorporate aaron's comments (10/16) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "media/base/text_track.h"
6
7 namespace media {
8
9 TextTrackConfig::TextTrackConfig()
10 : kind_(kTextNone) {
11 }
12
13 TextTrackConfig::TextTrackConfig(TextKind kind,
14 const std::string& label,
15 const std::string& language)
16 : kind_(kind),
17 label_(label_),
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 nit: s/_// in second label_
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
18 language_(language_) {
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 ditto
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
19 }
20
21 bool TextTrackConfig::Matches(const TextTrackConfig& config) const {
22 if (config.kind_ != kind_)
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 nit: Merge all this into a single return statement
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
23 return false;
24
25 if (config.label_ != label_)
26 return false;
27
28 if (config.language_ != language_)
29 return false;
30
31 return true;
32 }
33
34 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698