Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 237013002: Remove currently unused code (Closed)

Created:
6 years, 8 months ago by robertphillips
Modified:
6 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove currently unused code This code is currently unused and is contrary to the way in which we seem to be moving towards accomplishing this (i.e., device-specific optimization passes). This is a partial revert of r13704 (First version of bitmap use tracking in SkPictureRecord - https://codereview.chromium.org/187833003/) Committed: http://code.google.com/p/skia/source/detail?r=14179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -156 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D src/core/SkOffsetTable.h View 1 chunk +0 lines, -115 lines 0 comments Download
M src/core/SkPicturePlayback.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M src/core/SkPictureRecord.h View 3 chunks +0 lines, -4 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 7 chunks +5 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 8 months ago (2014-04-14 12:38:42 UTC) #1
reed1
lgtm
6 years, 8 months ago (2014-04-14 13:04:16 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-14 13:23:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/237013002/1
6 years, 8 months ago (2014-04-14 13:23:41 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 15:02:54 UTC) #5
Message was sent while issue was closed.
Change committed as 14179

Powered by Google App Engine
This is Rietveld 408576698