Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2369933004: Revert of [heap] Always use the passed-in collector in CollectGarbage. (Closed)

Created:
4 years, 2 months ago by Hannes Payer (out of office)
Modified:
4 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Always use the passed-in collector in CollectGarbage. (patchset #1 id:1 of https://codereview.chromium.org/2336943003/ ) Reason for revert: Regresses jank and memory. Revert for offline analysis. Original issue's description: > [heap] Always use the passed-in collector in CollectGarbage. > > Do not overwrite a collector decision. > > BUG= > > Committed: https://crrev.com/c19abaddafb5ede5e0d5efbe608b7fc5d7c7fcd0 > Cr-Commit-Position: refs/heads/master@{#39585} TBR=ulan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/d32d7e3211a09f24821ffa5334b7786520fe9c33 Cr-Commit-Position: refs/heads/master@{#39770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/heap/heap.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Hannes Payer (out of office)
Created Revert of [heap] Always use the passed-in collector in CollectGarbage.
4 years, 2 months ago (2016-09-27 12:40:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369933004/1
4 years, 2 months ago (2016-09-27 12:41:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 13:15:41 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 13:16:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d32d7e3211a09f24821ffa5334b7786520fe9c33
Cr-Commit-Position: refs/heads/master@{#39770}

Powered by Google App Engine
This is Rietveld 408576698