Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 2369613003: Require WebLocalFrame to be created with a non-null client (Closed)
Patch Set: oops Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebLocalFrame.h
diff --git a/third_party/WebKit/public/web/WebLocalFrame.h b/third_party/WebKit/public/web/WebLocalFrame.h
index dc4815df7ac7cc9a4db735fe1dfab17958392b25..39814cc78b782b3453dc88cff46f047ca273f28f 100644
--- a/third_party/WebKit/public/web/WebLocalFrame.h
+++ b/third_party/WebKit/public/web/WebLocalFrame.h
@@ -37,7 +37,7 @@ struct WebPrintPresetOptions;
class WebLocalFrame : public WebFrame {
public:
// Creates a WebFrame. Delete this WebFrame by calling WebFrame::close().
- // It is valid to pass a null client pointer.
+ // WebFrameClient may not be null.
esprehn 2016/09/29 04:28:42 we should probably pass a reference then
dcheng 2016/09/29 04:42:38 I'm not opposed to changing this, but it's inconsi
BLINK_EXPORT static WebLocalFrame* create(WebTreeScopeType, WebFrameClient*, WebFrame* opener = nullptr);
// Used to create a provisional local frame in prepration for replacing a

Powered by Google App Engine
This is Rietveld 408576698