Require WebLocalFrame to be created with a non-null client

third_party/WebKit/public/web/WebLocalFrame.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebLocalFrame_h
 #define WebLocalFrame_h
 
 #include "WebCompositionUnderline.h"
 #include "WebFrame.h"
 #include "WebFrameLoadType.h"
@@ skipping 19 matching lines @@
 struct WebFindOptions;
 struct WebFloatRect;
 struct WebPrintPresetOptions;
 
 // Interface for interacting with in process frames. This contains methods that
 // require interacting with a frame's document.
 // FIXME: Move lots of methods from WebFrame in here.
 class WebLocalFrame : public WebFrame {
 public:
     // Creates a WebFrame. Delete this WebFrame by calling WebFrame::close().
-    // It is valid to pass a null client pointer.
+    // WebFrameClient may not be null.

[esprehn, 2016/09/29 04:28:42]

we should probably pass a reference then

[dcheng, 2016/09/29 04:42:38]

I'm not opposed to changing this, but it's inconsistent with how all the
public/web interfaces are currently defined. If we want to change this, it might
be better to do a separate CL.

     BLINK_EXPORT static WebLocalFrame* create(WebTreeScopeType, WebFrameClient*, WebFrame* opener = nullptr);
 
     // Used to create a provisional local frame in prepration for replacing a
     // remote frame if the load commits. The returned frame is only partially
     // attached to the frame tree: it has the same parent as its potential
     // replacee but is invisible to the rest of the frames in the frame tree.
     // If the load commits, call swap() to fully attach this frame.
     BLINK_EXPORT static WebLocalFrame* createProvisional(WebFrameClient*, WebRemoteFrame*, WebSandboxFlags);
 
     // Returns the WebFrame associated with the current V8 context. This
@@ skipping 364 matching lines @@
     // to call these on a WebLocalFrame.
     bool isWebLocalFrame() const override = 0;
     WebLocalFrame* toWebLocalFrame() override = 0;
     bool isWebRemoteFrame() const override = 0;
     WebRemoteFrame* toWebRemoteFrame() override = 0;
 };
 
 } // namespace blink
 
 #endif // WebLocalFrame_h