Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2369583002: [Mac/GN] Add a product_type option to mac_app_bundle. (Closed)

Created:
4 years, 2 months ago by Robert Sesek
Modified:
4 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Add a package_type option to mac_app_bundle. The default is to produce a .app bundle. This CL also adds an option to produce a .xpc bundle, which is a MH_EXECUTE-type bundle structure with a different extension. BUG=604809 Committed: https://crrev.com/5ebcfa81e37ff1ebb2ef4baf00096598631c5aa2 Cr-Commit-Position: refs/heads/master@{#420760}

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -27 lines) Patch
M build/config/mac/rules.gni View 1 5 chunks +56 lines, -27 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Robert Sesek
4 years, 2 months ago (2016-09-23 20:48:33 UTC) #4
Nico
lgtm
4 years, 2 months ago (2016-09-23 21:27:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369583002/20001
4 years, 2 months ago (2016-09-23 21:59:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-23 22:50:44 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 22:53:03 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ebcfa81e37ff1ebb2ef4baf00096598631c5aa2
Cr-Commit-Position: refs/heads/master@{#420760}

Powered by Google App Engine
This is Rietveld 408576698