Adds debugging info to track down service launch race

Adds debugging info to track down service launch race

ServiceManager is trying to use an out-of-process native runner
in production, which is a big no-no. This adds some junk to help
track that down.

BUG=649673
TBR=ben@chromium.org

Committed: https://crrev.com/9f70a54d72609e8368a0c9e4c27b915400574da7
Cr-Commit-Position: refs/heads/master@{#420722}

[Ken Rockot(use gerrit already), 2016-09-23 18:35:31]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 18:36:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-09-23 18:36:19]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 18:36:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 18:48:54]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-09-23 19:26:35]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 19:27:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-09-23 19:46:58]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-09-23 19:46:59]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-09-23 19:47:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 20:46:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-23 20:48:04]

Description was changed from

==========
Adds debugging info to track down service launch race

ServiceManager is trying to use an out-of-process native runner
in production, which is a big no-no. This adds some junk to help
track that down.

BUG=649673
TBR=ben@chromium.org
==========

to

==========
Adds debugging info to track down service launch race

ServiceManager is trying to use an out-of-process native runner
in production, which is a big no-no. This adds some junk to help
track that down.

BUG=649673
TBR=ben@chromium.org

Committed: https://crrev.com/9f70a54d72609e8368a0c9e4c27b915400574da7
Cr-Commit-Position: refs/heads/master@{#420722}
==========

[commit-bot: I haz the power, 2016-09-23 20:48:05]

Patchset 3 (id:??) landed as
https://crrev.com/9f70a54d72609e8368a0c9e4c27b915400574da7
Cr-Commit-Position: refs/heads/master@{#420722}

[xhwang, 2016-12-03 00:25:31]

xhwang@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2016-12-03 00:25:32]

https://codereview.chromium.org/2369543002/diff/40001/services/shell/service_...
File services/shell/service_manager.cc (right):

https://codereview.chromium.org/2369543002/diff/40001/services/shell/service_...
services/shell/service_manager.cc:837: CHECK(false);
I am hitting this CHECK when running a ServiceTest with is_chrome_branded=true.
I feel the test is valid even with is_chrome_branded=true. Ideas?