Adds debugging info to track down service launch race

services/shell/service_manager.cc

Index: services/shell/service_manager.cc
diff --git a/services/shell/service_manager.cc b/services/shell/service_manager.cc
index 5e1de8467fe1d6f2d738fcf1758d13b7c543665f..cdd4ffb5ab478c36cae8ea7eb44cd83946e18daa 100644
--- a/services/shell/service_manager.cc
+++ b/services/shell/service_manager.cc
@@ -10,6 +10,7 @@
 
 #include "base/bind.h"
 #include "base/command_line.h"
+#include "base/debug/alias.h"
 #include "base/guid.h"
 #include "base/logging.h"
 #include "base/macros.h"
@@ -821,6 +822,20 @@ void ServiceManager::OnGotResolvedName(std::unique_ptr<ConnectParams> params,
                        instance_name);
       CreateServiceWithFactory(factory, target.name(), std::move(request));
     } else {
+      Identity source_instance_identity;
+      base::debug::Alias(&has_source_instance);
+      base::FilePath package_path = result->package_path;
+      base::debug::Alias(&package_path);
+      base::debug::Alias(&source);
+      base::debug::Alias(&target);
+      if (source_instance)
+        source_instance_identity = source_instance->identity();
+      base::debug::Alias(&source_instance_identity);
+#if defined(GOOGLE_CHROME_BUILD)
+      // We do not currently want to hit this code path in production, but it's
+      // happening somehow. https://crbug.com/649673.
+      CHECK(false);

[xhwang, 2016/12/03 00:25:31]

I am hitting this CHECK when running a ServiceTest with is_chrome_branded=true.
I feel the test is valid even with is_chrome_branded=true. Ideas?

+#endif
       instance->StartWithFilePath(result->package_path);
     }
   }