Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2369533002: Add Pixel C knobs to skpbench (Closed)

Created:
4 years, 3 months ago by csmartdalton
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -15 lines) Patch
M tools/skpbench/_benchresult.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skpbench/_hardware.py View 2 chunks +67 lines, -7 lines 0 comments Download
A tools/skpbench/_hardware_pixel_c.py View 1 chunk +94 lines, -0 lines 0 comments Download
M tools/skpbench/parseskpbench.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skpbench/skpbench.py View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 3 months ago (2016-09-23 17:52:10 UTC) #3
bsalomon
lgtm
4 years, 3 months ago (2016-09-23 18:18:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369533002/1
4 years, 3 months ago (2016-09-23 18:19:31 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 18:36:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bf41fa841b19ebab1eea7df573b3456dd6c5cac0

Powered by Google App Engine
This is Rietveld 408576698