Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: tools/skpbench/skpbench.py

Issue 2369533002: Add Pixel C knobs to skpbench (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/skpbench/parseskpbench.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/skpbench/skpbench.py
diff --git a/tools/skpbench/skpbench.py b/tools/skpbench/skpbench.py
index 6b226e0a579098841542325d480916639e52bdee..320cdc1bd312915860a4dd8670dad2b4ba364cef 100755
--- a/tools/skpbench/skpbench.py
+++ b/tools/skpbench/skpbench.py
@@ -20,14 +20,14 @@ import subprocess
import sys
import time
-__argparse = ArgumentParser(description='''
+__argparse = ArgumentParser(description="""
Executes the skpbench binary with various configs and skps.
Also monitors the output in order to filter out and re-run results that have an
unacceptable stddev.
-''')
+""")
__argparse.add_argument('--adb',
action='store_true', help="execute skpbench over adb")
@@ -82,7 +82,7 @@ class SubprocessMonitor(Thread):
Thread.__init__(self)
def run(self):
- '''Runs on the background thread.'''
+ """Runs on the background thread."""
for line in iter(self._proc.stdout.readline, b''):
self._queue.put(Message(Message.READLINE, line.decode('utf-8').rstrip()))
self._queue.put(Message(Message.EXIT))
@@ -243,8 +243,9 @@ def main():
if FLAGS.adb:
adb = Adb(FLAGS.device_serial)
model = adb.get_device_model()
- if False:
- pass # TODO: unique subclasses tailored to individual platforms.
+ if model == 'Pixel C':
+ from _hardware_pixel_c import HardwarePixelC
+ hardware = HardwarePixelC(adb)
else:
from _hardware_android import HardwareAndroid
print("WARNING: %s: don't know how to monitor this hardware; results "
« no previous file with comments | « tools/skpbench/parseskpbench.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698