Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2369453003: cocoa browser: add binding cmd+opt+l -> IDC_SHOW_DOWNLOADS (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa browser: add binding cmd+opt+l -> IDC_SHOW_DOWNLOADS Also, git cl format the table. BUG=418726 Committed: https://crrev.com/e4782406f9b29d7d4d87653f4edec682dbba8107 Cr-Commit-Position: refs/heads/master@{#420678}

Patch Set 1 #

Total comments: 2

Patch Set 2 : align comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Patch
M chrome/browser/global_keyboard_shortcuts_mac.mm View 1 1 chunk +31 lines, -30 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Elly Fong-Jones
avi: ptal? :)
4 years, 3 months ago (2016-09-23 17:12:39 UTC) #3
Avi (use Gerrit)
lgtm https://codereview.chromium.org/2369453003/diff/1/chrome/browser/global_keyboard_shortcuts_mac.mm File chrome/browser/global_keyboard_shortcuts_mac.mm (right): https://codereview.chromium.org/2369453003/diff/1/chrome/browser/global_keyboard_shortcuts_mac.mm#newcode50 chrome/browser/global_keyboard_shortcuts_mac.mm:50: //--- ----- ----- ------ Can we try to ...
4 years, 3 months ago (2016-09-23 17:42:02 UTC) #4
Elly Fong-Jones
https://codereview.chromium.org/2369453003/diff/1/chrome/browser/global_keyboard_shortcuts_mac.mm File chrome/browser/global_keyboard_shortcuts_mac.mm (right): https://codereview.chromium.org/2369453003/diff/1/chrome/browser/global_keyboard_shortcuts_mac.mm#newcode50 chrome/browser/global_keyboard_shortcuts_mac.mm:50: //--- ----- ----- ------ On 2016/09/23 17:42:02, Avi wrote: ...
4 years, 3 months ago (2016-09-23 17:52:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369453003/20001
4 years, 3 months ago (2016-09-23 17:53:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 18:48:28 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 18:49:51 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e4782406f9b29d7d4d87653f4edec682dbba8107
Cr-Commit-Position: refs/heads/master@{#420678}

Powered by Google App Engine
This is Rietveld 408576698