cocoa browser: add binding cmd+opt+l -> IDC_SHOW_DOWNLOADS

chrome/browser/global_keyboard_shortcuts_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/global_keyboard_shortcuts_mac.h"
 
 #import <AppKit/AppKit.h>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 28 matching lines @@
 // only if the tab contents is focused (BrowserKeyboardShortcut), and ones that
 // should work in all other cases (WindowKeyboardShortcut). In the latter case,
 // we differentiate between shortcuts that are checked before any other view
 // gets the chance to handle them (WindowKeyboardShortcut) or after all views
 // had a chance but did not handle the keypress event
 // (DelayedWindowKeyboardShortcut).
 
 const KeyboardShortcutData* GetWindowKeyboardShortcutTable(
     size_t* num_entries) {
   static const KeyboardShortcutData keyboard_shortcuts[] = {
-    //cmd   shift  cntrl  option
-    //---   -----  -----  ------
-    // '{' / '}' characters should be matched earlier than virtual key code
-    // (therefore we can match alt-8 as '{' on german keyboards).
-    {true,  false, false, false, 0,             '}', IDC_SELECT_NEXT_TAB},
-    {true,  false, false, false, 0,             '{', IDC_SELECT_PREVIOUS_TAB},
-    {false, false, true,  false, kVK_PageDown,  0,   IDC_SELECT_NEXT_TAB},
-    {false, false, true,  false, kVK_Tab,       0,   IDC_SELECT_NEXT_TAB},
-    {false, false, true,  false, kVK_PageUp,    0,   IDC_SELECT_PREVIOUS_TAB},
-    {false, true,  true,  false, kVK_Tab,       0,   IDC_SELECT_PREVIOUS_TAB},
-    // Cmd-0..8 select the Nth tab, with cmd-9 being "last tab".
-    {true,  false, false, false, kVK_ANSI_1,          0, IDC_SELECT_TAB_0},
-    {true,  false, false, false, kVK_ANSI_Keypad1,    0, IDC_SELECT_TAB_0},
-    {true,  false, false, false, kVK_ANSI_2,          0, IDC_SELECT_TAB_1},
-    {true,  false, false, false, kVK_ANSI_Keypad2,    0, IDC_SELECT_TAB_1},
-    {true,  false, false, false, kVK_ANSI_3,          0, IDC_SELECT_TAB_2},
-    {true,  false, false, false, kVK_ANSI_Keypad3,    0, IDC_SELECT_TAB_2},
-    {true,  false, false, false, kVK_ANSI_4,          0, IDC_SELECT_TAB_3},
-    {true,  false, false, false, kVK_ANSI_Keypad4,    0, IDC_SELECT_TAB_3},
-    {true,  false, false, false, kVK_ANSI_5,          0, IDC_SELECT_TAB_4},
-    {true,  false, false, false, kVK_ANSI_Keypad5,    0, IDC_SELECT_TAB_4},
-    {true,  false, false, false, kVK_ANSI_6,          0, IDC_SELECT_TAB_5},
-    {true,  false, false, false, kVK_ANSI_Keypad6,    0, IDC_SELECT_TAB_5},
-    {true,  false, false, false, kVK_ANSI_7,          0, IDC_SELECT_TAB_6},
-    {true,  false, false, false, kVK_ANSI_Keypad7,    0, IDC_SELECT_TAB_6},
-    {true,  false, false, false, kVK_ANSI_8,          0, IDC_SELECT_TAB_7},
-    {true,  false, false, false, kVK_ANSI_Keypad8,    0, IDC_SELECT_TAB_7},
-    {true,  false, false, false, kVK_ANSI_9,          0, IDC_SELECT_LAST_TAB},
-    {true,  false, false, false, kVK_ANSI_Keypad9,    0, IDC_SELECT_LAST_TAB},
-    {true,  true,  false, false, kVK_ANSI_M,          0, IDC_SHOW_AVATAR_MENU},
+      // cmd   shift  cntrl  option
+      //---   -----  -----  ------

[Avi (use Gerrit), 2016/09/23 17:42:02]

Can we try to align these comments with the constants below? At least stick a
space to the left of the first "---" here.

[Elly Fong-Jones, 2016/09/23 17:52:31]

Hm. There's not a lot to be done because 'git cl format' ruins the alignment of
the table columns. :\ I can at least stick the space in though.

+      // '{' / '}' characters should be matched earlier than virtual key code
+      // (therefore we can match alt-8 as '{' on german keyboards).
+      {true, false, false, false, 0, '}', IDC_SELECT_NEXT_TAB},
+      {true, false, false, false, 0, '{', IDC_SELECT_PREVIOUS_TAB},
+      {false, false, true, false, kVK_PageDown, 0, IDC_SELECT_NEXT_TAB},
+      {false, false, true, false, kVK_Tab, 0, IDC_SELECT_NEXT_TAB},
+      {false, false, true, false, kVK_PageUp, 0, IDC_SELECT_PREVIOUS_TAB},
+      {false, true, true, false, kVK_Tab, 0, IDC_SELECT_PREVIOUS_TAB},
+      // Cmd-0..8 select the Nth tab, with cmd-9 being "last tab".
+      {true, false, false, false, kVK_ANSI_1, 0, IDC_SELECT_TAB_0},
+      {true, false, false, false, kVK_ANSI_Keypad1, 0, IDC_SELECT_TAB_0},
+      {true, false, false, false, kVK_ANSI_2, 0, IDC_SELECT_TAB_1},
+      {true, false, false, false, kVK_ANSI_Keypad2, 0, IDC_SELECT_TAB_1},
+      {true, false, false, false, kVK_ANSI_3, 0, IDC_SELECT_TAB_2},
+      {true, false, false, false, kVK_ANSI_Keypad3, 0, IDC_SELECT_TAB_2},
+      {true, false, false, false, kVK_ANSI_4, 0, IDC_SELECT_TAB_3},
+      {true, false, false, false, kVK_ANSI_Keypad4, 0, IDC_SELECT_TAB_3},
+      {true, false, false, false, kVK_ANSI_5, 0, IDC_SELECT_TAB_4},
+      {true, false, false, false, kVK_ANSI_Keypad5, 0, IDC_SELECT_TAB_4},
+      {true, false, false, false, kVK_ANSI_6, 0, IDC_SELECT_TAB_5},
+      {true, false, false, false, kVK_ANSI_Keypad6, 0, IDC_SELECT_TAB_5},
+      {true, false, false, false, kVK_ANSI_7, 0, IDC_SELECT_TAB_6},
+      {true, false, false, false, kVK_ANSI_Keypad7, 0, IDC_SELECT_TAB_6},
+      {true, false, false, false, kVK_ANSI_8, 0, IDC_SELECT_TAB_7},
+      {true, false, false, false, kVK_ANSI_Keypad8, 0, IDC_SELECT_TAB_7},
+      {true, false, false, false, kVK_ANSI_9, 0, IDC_SELECT_LAST_TAB},
+      {true, false, false, false, kVK_ANSI_Keypad9, 0, IDC_SELECT_LAST_TAB},
+      {true, true, false, false, kVK_ANSI_M, 0, IDC_SHOW_AVATAR_MENU},
+      {true, false, false, true, 0, 'l', IDC_SHOW_DOWNLOADS},
   };
 
   *num_entries = arraysize(keyboard_shortcuts);
 
   return keyboard_shortcuts;
 }
 
 const KeyboardShortcutData* GetDelayedWindowKeyboardShortcutTable(
     size_t* num_entries) {
   static const KeyboardShortcutData keyboard_shortcuts[] = {
@@ skipping 201 matching lines @@
       }
     }
 
     // opt/alt modifier is set (e.g. on german layout we want '{' for opt-8).
     if ([event modifierFlags] & NSAlternateKeyMask)
       return rawChar;
   }
 
   return noModifiersChar;
 }