Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3095)

Unified Diff: device/bluetooth/bluetooth_device.h

Issue 2369423003: bluetooth: Expose service data from BlueZ (Closed)
Patch Set: Change scope to not cover just dbus property Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_device.h
diff --git a/device/bluetooth/bluetooth_device.h b/device/bluetooth/bluetooth_device.h
index b2dfdedce2c0040286c69cac587ad5dff39d2137..fa59b3aff4f3f4312c4906af1be60eec26ffee0a 100644
--- a/device/bluetooth/bluetooth_device.h
+++ b/device/bluetooth/bluetooth_device.h
@@ -11,6 +11,7 @@
#include <memory>
#include <set>
#include <string>
+#include <unordered_map>
#include <unordered_set>
#include <vector>
@@ -329,11 +330,11 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
// Returns the UUIDs of services for which the device advertises Service Data.
// Returns an empty set if the adapter is not discovering.
- UUIDSet GetServiceDataUUIDs() const;
+ virtual UUIDSet GetServiceDataUUIDs() const;
ortuno 2016/09/28 08:39:24 Please also implement GetServiceData()
puthik_chromium 2016/10/05 00:11:33 Fix this by use Property change event to update se
// Returns a pointer to the Service Data for Service with |uuid|. Returns
// nullptr if |uuid| has no Service Data.
- const std::vector<uint8_t>* GetServiceDataForUUID(
+ virtual const std::vector<uint8_t>* GetServiceDataForUUID(
const BluetoothUUID& uuid) const;
// The received signal strength, in dBm. This field is avaliable and valid
@@ -583,7 +584,7 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
BluetoothDevice::UUIDSet device_uuids_;
};
- BluetoothDevice(BluetoothAdapter* adapter);
+ explicit BluetoothDevice(BluetoothAdapter* adapter);
// Implements platform specific operations to initiate a GATT connection.
// Subclasses must also call DidConnectGatt, DidFailToConnectGatt, or

Powered by Google App Engine
This is Rietveld 408576698