bluetooth: Expose service data from BlueZ

device/bluetooth/bluetooth_device.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <set>
 #include <string>
+#include <unordered_map>
 #include <unordered_set>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/optional.h"
 #include "base/strings/string16.h"
 #include "base/time/time.h"
@@ skipping 298 matching lines @@
   // a device stops advertising a service this function will still return
   // its UUID.
   virtual UUIDSet GetUUIDs() const;
 
   // Returns the last advertised Service Data. Returns an empty map if the
   // adapter is not discovering.
   const ServiceDataMap& GetServiceData() const;
 
   // Returns the UUIDs of services for which the device advertises Service Data.
   // Returns an empty set if the adapter is not discovering.
-  UUIDSet GetServiceDataUUIDs() const;
+  virtual UUIDSet GetServiceDataUUIDs() const;

[ortuno, 2016/09/28 08:39:24]

Please also implement GetServiceData()

[puthik_chromium, 2016/10/05 00:11:33]

Fix this by use Property change event to update service_data_ and remove these
code instead.

 
   // Returns a pointer to the Service Data for Service with |uuid|. Returns
   // nullptr if |uuid| has no Service Data.
-  const std::vector<uint8_t>* GetServiceDataForUUID(
+  virtual const std::vector<uint8_t>* GetServiceDataForUUID(
       const BluetoothUUID& uuid) const;
 
   // The received signal strength, in dBm. This field is avaliable and valid
   // only during discovery.
   // TODO(http://crbug.com/580406): Devirtualize once BlueZ sets inquiry_rssi_.
   virtual base::Optional<int8_t> GetInquiryRSSI() const;
 
   // The transmitted power level. This field is avaliable only for LE devices
   // that include this field in AD. It is avaliable and valid only during
   // discovery.
@@ skipping 229 matching lines @@
     const UUIDSet& GetUUIDs() const;
 
    private:
     void UpdateDeviceUUIDs();
 
     BluetoothDevice::UUIDSet advertised_uuids_;
     BluetoothDevice::UUIDSet service_uuids_;
     BluetoothDevice::UUIDSet device_uuids_;
   };
 
-  BluetoothDevice(BluetoothAdapter* adapter);
+  explicit BluetoothDevice(BluetoothAdapter* adapter);
 
   // Implements platform specific operations to initiate a GATT connection.
   // Subclasses must also call DidConnectGatt, DidFailToConnectGatt, or
   // DidDisconnectGatt immediately or asynchronously as the connection state
   // changes.
   virtual void CreateGattConnectionImpl() = 0;
 
   // Disconnects GATT connection on platforms that maintain a specific GATT
   // connection.
   virtual void DisconnectGatt() = 0;
@@ skipping 50 matching lines @@
 
  private:
   // Returns a localized string containing the device's bluetooth address and
   // a device type for display when |name_| is empty.
   base::string16 GetAddressWithLocalizedDeviceTypeName() const;
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_