Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py

Issue 2369333002: [Findit] Capture versionized metadata for master_flake_analysis (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py b/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py
index 2795f896262e397a05c0f0c89544c6f45582be92..0f952e8b80615f454bd108e46eb551224c622d7d 100644
--- a/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py
+++ b/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py
@@ -83,7 +83,7 @@ _SAMPLE_FAILURE_LOG = {
}
]
}
-_EXPECTED_TESTS_STATUESE = {
+_EXPECTED_TEST_STATUS = {
'TestSuite1.test1': {
'total_run': 2,
'SUCCESS': 2
@@ -147,15 +147,14 @@ class ProcessFlakeSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):
self.test_name)
tests_statuses = (
ProcessFlakeSwarmingTaskResultPipeline._CheckTestsRunStatuses(
- self.pipeline, None, *call_params
- ))
+ self.pipeline, None, *call_params))
self.assertEqual({}, tests_statuses)
def testCheckTestsRunStatuses(self):
analysis = MasterFlakeAnalysis.Create(
self.master_name, self.builder_name,
self.build_number, self.step_name, self.test_name)
- analysis.put()
+ analysis.Save()
task = FlakeSwarmingTask.Create(
self.master_name, self.builder_name,
@@ -171,14 +170,14 @@ class ProcessFlakeSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):
ProcessFlakeSwarmingTaskResultPipeline._CheckTestsRunStatuses(
self.pipeline,
_SAMPLE_FAILURE_LOG, *call_params))
- self.assertEqual(_EXPECTED_TESTS_STATUESE, tests_statuses)
+ self.assertEqual(_EXPECTED_TEST_STATUS, tests_statuses)
- def testCheckTestsRunStatusesWhenTestNotExist(self):
+ def testCheckTestsRunStatusesWhenTestDoesNotExist(self):
test_name = 'TestSuite1.new_test'
analysis = MasterFlakeAnalysis.Create(
self.master_name, self.builder_name,
self.build_number, self.step_name, test_name)
- analysis.put()
+ analysis.Save()
task = FlakeSwarmingTask.Create(
self.master_name, self.builder_name,
@@ -190,7 +189,7 @@ class ProcessFlakeSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):
_SAMPLE_FAILURE_LOG, self.master_name, self.builder_name,
self.build_number, self.step_name, self.build_number, test_name)
- self.assertEqual(_EXPECTED_TESTS_STATUESE, tests_statuses)
+ self.assertEqual(_EXPECTED_TEST_STATUS, tests_statuses)
task = FlakeSwarmingTask.Get(
self.master_name, self.builder_name,
@@ -198,10 +197,10 @@ class ProcessFlakeSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):
self.assertEqual(0, task.tries)
self.assertEqual(0, task.successes)
- analysis = MasterFlakeAnalysis.Get(
+ analysis = MasterFlakeAnalysis.GetVersion(
self.master_name, self.builder_name,
self.build_number, self.step_name, test_name)
- self.assertTrue(analysis.success_rates[-1] < 0)
+ self.assertTrue(analysis.pass_rates[-1] < 0)
def _MockedGetSwarmingTaskFailureLog(self, *_):
return _SAMPLE_FAILURE_LOG
@@ -220,7 +219,7 @@ class ProcessFlakeSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):
analysis = MasterFlakeAnalysis.Create(
self.master_name, self.builder_name,
self.build_number, self.step_name, self.test_name)
- analysis.put()
+ analysis.Save()
pipeline = ProcessFlakeSwarmingTaskResultPipeline()
step_name, task_info = pipeline.run(
@@ -235,7 +234,7 @@ class ProcessFlakeSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):
self.step_name, self.test_name)
self.assertEqual(analysis_status.COMPLETED, task.status)
- self.assertEqual(_EXPECTED_TESTS_STATUESE, task.tests_statuses)
+ self.assertEqual(_EXPECTED_TEST_STATUS, task.tests_statuses)
self.assertEqual(datetime.datetime(2016, 2, 10, 18, 32, 6, 538220),
task.created_time)
@@ -254,7 +253,7 @@ class ProcessFlakeSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):
analysis = MasterFlakeAnalysis.Create(
self.master_name, self.builder_name,
self.build_number, self.step_name, self.test_name)
- analysis.put()
+ analysis.Save()
pipeline = ProcessFlakeSwarmingTaskResultPipeline()
step_name, task_info = pipeline.run(

Powered by Google App Engine
This is Rietveld 408576698