Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2198)

Unified Diff: appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

Issue 2369333002: [Findit] Capture versionized metadata for master_flake_analysis (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
diff --git a/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py b/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
index 0eb8285f6e4e80b21d659998dbdb4780eb171b8c..a4b6c11daf5c1451497a0b7da75563d600a4bf35 100644
--- a/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
+++ b/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
@@ -4,10 +4,8 @@
from collections import defaultdict
-from common.pipeline_wrapper import BasePipeline
-
-from model.flake.master_flake_analysis import MasterFlakeAnalysis
from model.flake.flake_swarming_task import FlakeSwarmingTask
+from model.flake.master_flake_analysis import MasterFlakeAnalysis
from waterfall.process_base_swarming_task_result_pipeline import (
ProcessBaseSwarmingTaskResultPipeline)
@@ -59,21 +57,29 @@ class ProcessFlakeSwarmingTaskResultPipeline(
successes = tests_statuses.get(test_name, {}).get('SUCCESS', 0)
if tries > 0:
- success_rate = successes * 1.0 / tries
+ pass_rate = successes * 1.0 / tries
else:
- success_rate = -1 # Special value to indicate test is not existing.
+ pass_rate = -1 # Special value to indicate test is not existing.
+
+ master_flake_analysis = MasterFlakeAnalysis.GetVersion(
+ master_name, builder_name, master_build_number, step_name, test_name)
+ master_flake_analysis.build_numbers.append(build_number)
+ master_flake_analysis.pass_rates.append(pass_rate)
- master_flake_analysis = MasterFlakeAnalysis.Get(master_name, builder_name,
- master_build_number,
- step_name, test_name)
flake_swarming_task = FlakeSwarmingTask.Get(
master_name, builder_name, build_number, step_name, test_name)
-
- master_flake_analysis.build_numbers.append(build_number)
- master_flake_analysis.success_rates.append(success_rate)
flake_swarming_task.tries = tries
flake_swarming_task.successes = successes
flake_swarming_task.put()
+
+ results = flake_swarming_task.ResultsToDict()
+ # TODO(lijeffrey): Determine whether or not this flake swarming task
+ # was a cache hit (already ran results for more iterations than were
+ # requested) and update results['cache_hit'] accordingly.
+ results['cache_hit'] = False
+
+ task_id = flake_swarming_task.task_id
+ master_flake_analysis.swarming_rerun_results[task_id] = results
master_flake_analysis.put()
return tests_statuses

Powered by Google App Engine
This is Rietveld 408576698