|
|
DescriptionSimplify FPDF_RenderPage().
Committed: https://pdfium.googlesource.com/pdfium/+/84144e88da8d2bbd03ba9f8608d5603a18b4d480
Patch Set 1 #
Total comments: 2
Patch Set 2 : More unique_ptr #Messages
Total messages: 17 (11 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thestig@chromium.org changed reviewers: + tsepez@chromium.org, weili@chromium.org
https://codereview.chromium.org/2369323004/diff/1/fpdfsdk/fpdfview.cpp File fpdfsdk/fpdfview.cpp (right): https://codereview.chromium.org/2369323004/diff/1/fpdfsdk/fpdfview.cpp#newcod... fpdfsdk/fpdfview.cpp:578: CFX_DIBitmap* pBitmap = nullptr; Can this be an unique_ptr? It looks like it only gets assigned to if bNewBitmap, hence its fine to have it go out of scope as null even if thats not the case?
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2369323004/diff/1/fpdfsdk/fpdfview.cpp File fpdfsdk/fpdfview.cpp (right): https://codereview.chromium.org/2369323004/diff/1/fpdfsdk/fpdfview.cpp#newcod... fpdfsdk/fpdfview.cpp:578: CFX_DIBitmap* pBitmap = nullptr; On 2016/09/27 21:25:32, Tom Sepez wrote: > Can this be an unique_ptr? It looks like it only gets assigned to if > bNewBitmap, hence its fine to have it go out of scope as null even if thats not > the case? Done.
lgtm
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Simplify FPDF_RenderPage(). ========== to ========== Simplify FPDF_RenderPage(). Committed: https://pdfium.googlesource.com/pdfium/+/84144e88da8d2bbd03ba9f8608d5603a18b4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://pdfium.googlesource.com/pdfium/+/84144e88da8d2bbd03ba9f8608d5603a18b4... |