Simplify FPDF_RenderPage().

Simplify FPDF_RenderPage().

Committed: https://pdfium.googlesource.com/pdfium/+/84144e88da8d2bbd03ba9f8608d5603a18b4d480

[Lei Zhang, 2016-09-27 20:54:02]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 20:54:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 21:04:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 21:04:19]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-27 21:08:45]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[Tom Sepez, 2016-09-27 21:25:33]

https://codereview.chromium.org/2369323004/diff/1/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/2369323004/diff/1/fpdfsdk/fpdfview.cpp#newcod...
fpdfsdk/fpdfview.cpp:578: CFX_DIBitmap* pBitmap = nullptr;
Can this be an unique_ptr?  It looks like it only gets assigned to if
bNewBitmap, hence its fine to have it go out of scope as null even if thats not
the case?

[Lei Zhang, 2016-09-27 21:38:40]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 21:38:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 21:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 21:49:12]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-27 21:49:46]

https://codereview.chromium.org/2369323004/diff/1/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/2369323004/diff/1/fpdfsdk/fpdfview.cpp#newcod...
fpdfsdk/fpdfview.cpp:578: CFX_DIBitmap* pBitmap = nullptr;
On 2016/09/27 21:25:32, Tom Sepez wrote:
> Can this be an unique_ptr?  It looks like it only gets assigned to if
> bNewBitmap, hence its fine to have it go out of scope as null even if thats
not
> the case?

Done.

[Tom Sepez, 2016-09-27 21:51:51]

lgtm

[Lei Zhang, 2016-09-27 22:05:43]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-09-27 22:05:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 22:06:03]

Description was changed from

==========
Simplify FPDF_RenderPage().
==========

to

==========
Simplify FPDF_RenderPage().

Committed:
https://pdfium.googlesource.com/pdfium/+/84144e88da8d2bbd03ba9f8608d5603a18b4...
==========

[commit-bot: I haz the power, 2016-09-27 22:06:04]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/84144e88da8d2bbd03ba9f8608d5603a18b4...