Set status tray height to 37px on login screen

The height of the status tray should be 37px, but it wasn't on login and lock screen. This patch fixes it.

Major changes:
1) Sets the minimum height 37px (kTrayItemSize actually)
2) Removes the vertical margin of web notification tray. this is no longer necessary thanks to #1.
3) Removes the hack for win in ShelfLayoutManagerTest::StatusAreaHitBoxCoversEdge.

BUG=641377
TEST=see the notification tray manually with MD and non-MD mode

Committed: https://crrev.com/b94365f59e52eace812d71d97c2469d68caac9c3
Cr-Commit-Position: refs/heads/master@{#421790}

[yoshiki, 2016-09-27 08:51:52]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 08:52:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 09:15:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 09:15:55]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yoshiki, 2016-09-27 11:43:03]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 11:43:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 12:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 12:17:18]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yoshiki, 2016-09-27 13:50:11]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 13:50:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 14:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 14:45:55]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2016-09-28 18:57:53]

Description was changed from

==========
.

BUG=
==========

to

==========
The height of the status tray should be 37px, but it wasn't on lock screen. This
patch fixes it.

Major changes:
1) Sets the minimum height 37px (kTrayItemSize actually)
2) Removes the vertical margin of web notification tray. this is no longer
necessary thanks to #1.
3) Removes the hack for win in
ShelfLayoutManagerTest::StatusAreaHitBoxCoversEdge.

BUG=641377
==========

[yoshiki, 2016-09-28 19:03:48]

Patchset #2 (id:20001) has been deleted

[yoshiki, 2016-09-28 19:03:56]

Patchset #1 (id:1) has been deleted

[yoshiki, 2016-09-28 19:07:39]

Description was changed from

==========
The height of the status tray should be 37px, but it wasn't on lock screen. This
patch fixes it.

Major changes:
1) Sets the minimum height 37px (kTrayItemSize actually)
2) Removes the vertical margin of web notification tray. this is no longer
necessary thanks to #1.
3) Removes the hack for win in
ShelfLayoutManagerTest::StatusAreaHitBoxCoversEdge.

BUG=641377
==========

to

==========
The height of the status tray should be 37px, but it wasn't on lock screen. This
patch fixes it.

Major changes:
1) Sets the minimum height 37px (kTrayItemSize actually)
2) Removes the vertical margin of web notification tray. this is no longer
necessary thanks to #1.
3) Removes the hack for win in
ShelfLayoutManagerTest::StatusAreaHitBoxCoversEdge.

BUG=641377
TEST=see the notification tray manually with MD and non-MD mode
==========

[yoshiki, 2016-09-28 19:07:39]

yoshiki@chromium.org changed reviewers:
+ jennyz@chromium.org

[yoshiki, 2016-09-28 19:07:51]

Jenny, PTAL. Thanks.

[yoshiki, 2016-09-28 19:08:19]

Description was changed from

==========
The height of the status tray should be 37px, but it wasn't on lock screen. This
patch fixes it.

Major changes:
1) Sets the minimum height 37px (kTrayItemSize actually)
2) Removes the vertical margin of web notification tray. this is no longer
necessary thanks to #1.
3) Removes the hack for win in
ShelfLayoutManagerTest::StatusAreaHitBoxCoversEdge.

BUG=641377
TEST=see the notification tray manually with MD and non-MD mode
==========

to

==========
The height of the status tray should be 37px, but it wasn't on login and lock
screen. This patch fixes it.

Major changes:
1) Sets the minimum height 37px (kTrayItemSize actually)
2) Removes the vertical margin of web notification tray. this is no longer
necessary thanks to #1.
3) Removes the hack for win in
ShelfLayoutManagerTest::StatusAreaHitBoxCoversEdge.

BUG=641377
TEST=see the notification tray manually with MD and non-MD mode
==========

[jennyz, 2016-09-28 21:53:51]

lgtm

[yoshiki, 2016-09-29 00:27:50]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2016-09-29 00:28:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 00:37:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 00:37:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoshiki, 2016-09-29 08:11:51]

yoshiki@chromium.org changed reviewers:
+ skuhne@chromium.org

[yoshiki, 2016-09-29 08:12:42]

skuhne@, PTAL at ash/shelf/shelf_layout_manager_unittest.cc. Thanks.

[Mr4D (OOO till 08-26), 2016-09-29 08:24:52]

https://codereview.chromium.org/2369293002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager_unittest.cc (left):

https://codereview.chromium.org/2369293002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager_unittest.cc:1894: #if !defined(OS_WIN)
Did you test this on (MS) Windows? Are you sure this works?

[yoshiki, 2016-09-29 08:29:40]

https://codereview.chromium.org/2369293002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager_unittest.cc (left):

https://codereview.chromium.org/2369293002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager_unittest.cc:1894: #if !defined(OS_WIN)
On 2016/09/29 08:24:52, Mr4D wrote:
> Did you test this on (MS) Windows? Are you sure this works?

I didn't test it locally but tested on trybot. This test was failed on trybot
without this patch.

[Mr4D (OOO till 08-26), 2016-09-29 08:55:34]

lgtm

[yoshiki, 2016-09-29 09:36:04]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2016-09-29 09:36:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 09:42:17]

Description was changed from

==========
The height of the status tray should be 37px, but it wasn't on login and lock
screen. This patch fixes it.

Major changes:
1) Sets the minimum height 37px (kTrayItemSize actually)
2) Removes the vertical margin of web notification tray. this is no longer
necessary thanks to #1.
3) Removes the hack for win in
ShelfLayoutManagerTest::StatusAreaHitBoxCoversEdge.

BUG=641377
TEST=see the notification tray manually with MD and non-MD mode
==========

to

==========
The height of the status tray should be 37px, but it wasn't on login and lock
screen. This patch fixes it.

Major changes:
1) Sets the minimum height 37px (kTrayItemSize actually)
2) Removes the vertical margin of web notification tray. this is no longer
necessary thanks to #1.
3) Removes the hack for win in
ShelfLayoutManagerTest::StatusAreaHitBoxCoversEdge.

BUG=641377
TEST=see the notification tray manually with MD and non-MD mode
==========

[commit-bot: I haz the power, 2016-09-29 09:42:18]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-09-29 09:45:24]

Description was changed from

==========
The height of the status tray should be 37px, but it wasn't on login and lock
screen. This patch fixes it.

Major changes:
1) Sets the minimum height 37px (kTrayItemSize actually)
2) Removes the vertical margin of web notification tray. this is no longer
necessary thanks to #1.
3) Removes the hack for win in
ShelfLayoutManagerTest::StatusAreaHitBoxCoversEdge.

BUG=641377
TEST=see the notification tray manually with MD and non-MD mode
==========

to

==========
The height of the status tray should be 37px, but it wasn't on login and lock
screen. This patch fixes it.

Major changes:
1) Sets the minimum height 37px (kTrayItemSize actually)
2) Removes the vertical margin of web notification tray. this is no longer
necessary thanks to #1.
3) Removes the hack for win in
ShelfLayoutManagerTest::StatusAreaHitBoxCoversEdge.

BUG=641377
TEST=see the notification tray manually with MD and non-MD mode

Committed: https://crrev.com/b94365f59e52eace812d71d97c2469d68caac9c3
Cr-Commit-Position: refs/heads/master@{#421790}
==========

[commit-bot: I haz the power, 2016-09-29 09:45:25]

Patchset 1 (id:??) landed as
https://crrev.com/b94365f59e52eace812d71d97c2469d68caac9c3
Cr-Commit-Position: refs/heads/master@{#421790}