Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: ash/shelf/shelf_layout_manager_unittest.cc

Issue 2369293002: Set status tray height to 37px on login screen (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/system/web_notification/web_notification_tray.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_layout_manager_unittest.cc
diff --git a/ash/shelf/shelf_layout_manager_unittest.cc b/ash/shelf/shelf_layout_manager_unittest.cc
index d3e5f95b170f2825805e3ed934078f0464dc5bb0..67a216180b95dcf573dc7b8e2b1ee037ba02b9fd 100644
--- a/ash/shelf/shelf_layout_manager_unittest.cc
+++ b/ash/shelf/shelf_layout_manager_unittest.cc
@@ -1891,11 +1891,8 @@ TEST_F(ShelfLayoutManagerTest, StatusAreaHitBoxCoversEdge) {
GetPrimaryShelf()->SetAlignment(SHELF_ALIGNMENT_BOTTOM);
generator.MoveMouseTo(inset_display_bounds.bottom_right());
EXPECT_FALSE(status_area_widget->IsMessageBubbleShown());
-#if !defined(OS_WIN)
Mr4D (OOO till 08-26) 2016/09/29 08:24:52 Did you test this on (MS) Windows? Are you sure th
yoshiki 2016/09/29 08:29:40 I didn't test it locally but tested on trybot. Thi
generator.ClickLeftButton();
- // The bottom right pixel doesn't work on Windows; see crbug.com/633434
EXPECT_TRUE(status_area_widget->IsMessageBubbleShown());
-#endif
generator.ClickLeftButton();
EXPECT_FALSE(status_area_widget->IsMessageBubbleShown());
@@ -1903,11 +1900,8 @@ TEST_F(ShelfLayoutManagerTest, StatusAreaHitBoxCoversEdge) {
GetPrimaryShelf()->SetAlignment(SHELF_ALIGNMENT_RIGHT);
generator.MoveMouseTo(inset_display_bounds.bottom_right());
EXPECT_FALSE(status_area_widget->IsMessageBubbleShown());
-#if !defined(OS_WIN)
generator.ClickLeftButton();
- // The bottom right pixel doesn't work on Windows; see crbug.com/633434
EXPECT_TRUE(status_area_widget->IsMessageBubbleShown());
-#endif
generator.ClickLeftButton();
EXPECT_FALSE(status_area_widget->IsMessageBubbleShown());
« no previous file with comments | « ash/common/system/web_notification/web_notification_tray.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698