Update descriptions and owners for permissions metrics.

Update descriptions and owners for permissions metrics.

Some of the descriptions have been updated to be more accurate and
reflect the fact that they are probably not metrics you want to use.

BUG=625920, 638076
Committed: https://crrev.com/f1f026f4dc5b30ceb5061a12057f32c56cc12a1e
Cr-Commit-Position: refs/heads/master@{#421770}

[benwells, 2016-09-27 06:41:39]

benwells@chromium.org changed reviewers:
+ dominickn@chromium.org, kcarattini@chromium.org

[dominickn, 2016-09-27 06:58:01]

lgtm % nit

https://codereview.chromium.org/2369273002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2369273002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:6952: +   
ContentSettings.PermissionsActions*.
Missing end of sentence here?

[kcarattini, 2016-09-27 06:58:47]

lgtm

Thanks.

And thanks for reminding me what a mess this all is. You can add 638076 to the
bug list as well.

Kendra

[benwells, 2016-09-27 07:06:06]

Description was changed from

==========
Update descriptions and owners for permissions metrics.

Some of the descriptions have been updated to be more accurate and
reflect the fact that they are probably not metrics you want to use.

BUG=625920
==========

to

==========
Update descriptions and owners for permissions metrics.

Some of the descriptions have been updated to be more accurate and
reflect the fact that they are probably not metrics you want to use.

BUG=625920, 638076
==========

[benwells, 2016-09-27 07:06:57]

benwells@chromium.org changed reviewers:
+ isherman@chromium.org

[benwells, 2016-09-27 07:06:58]

+isherman

https://codereview.chromium.org/2369273002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2369273002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:6952: +   
ContentSettings.PermissionsActions*.
On 2016/09/27 06:58:00, dominickn wrote:
> Missing end of sentence here?

Done.

[Ilya Sherman, 2016-09-27 21:07:46]

Thanks for taking the time to do some cleanup here!

https://codereview.chromium.org/2369273002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2369273002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:6910: +   
ContentSettings.PermissionsActions*, or Permissions.Prompt.*.
Hmm, that's a lot of caveats!  Is there still value to recording this metric, or
is it time to deprecate it?

https://codereview.chromium.org/2369273002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:41370: +    permissions.
Same question.  Also, is there a better metric that you could point the viewer
toward?

[benwells, 2016-09-28 04:03:17]

On 2016/09/27 21:07:46, Ilya Sherman wrote:
> Thanks for taking the time to do some cleanup here!
> 
>
https://codereview.chromium.org/2369273002/diff/20001/tools/metrics/histogram...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/2369273002/diff/20001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:6910: +   
> ContentSettings.PermissionsActions*, or Permissions.Prompt.*.
> Hmm, that's a lot of caveats!  Is there still value to recording this metric,
or
> is it time to deprecate it?

Yep, we're working to deprecate them, see the second linked issue. I think it
might take some time to check everything is covered / there is no value.

> 
>
https://codereview.chromium.org/2369273002/diff/20001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:41370: +    permissions.
> Same question.  Also, is there a better metric that you could point the viewer
> toward?

Unfortunately, not at the moment as this one splits in a specific way.

[benwells, 2016-09-28 04:03:21]

The CQ bit was checked by benwells@chromium.org

[benwells, 2016-09-28 04:03:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, kcarattini@chromium.org
Link to the patchset: https://codereview.chromium.org/2369273002/#ps20001
(title: "Fix nit")

[commit-bot: I haz the power, 2016-09-28 04:03:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 04:12:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 04:12:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ilya Sherman, 2016-09-28 23:16:16]

Okay, got it.  LGTM, but please add a crbug link to the each histogram that is
labeled as "probably not the metric you want".

[benwells, 2016-09-29 06:35:49]

On 2016/09/28 23:16:16, Ilya Sherman wrote:
> Okay, got it.  LGTM, but please add a crbug link to the each histogram that is
> labeled as "probably not the metric you want".

Sure, done. Sorry for trying to land this, for some reason I thought you'd lg'd
it before....
Yay for presubmit checks!

[benwells, 2016-09-29 06:35:58]

The CQ bit was checked by benwells@chromium.org

[benwells, 2016-09-29 06:35:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, kcarattini@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2369273002/#ps40001
(title: "Feedback")

[commit-bot: I haz the power, 2016-09-29 06:36:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 07:35:59]

Description was changed from

==========
Update descriptions and owners for permissions metrics.

Some of the descriptions have been updated to be more accurate and
reflect the fact that they are probably not metrics you want to use.

BUG=625920, 638076
==========

to

==========
Update descriptions and owners for permissions metrics.

Some of the descriptions have been updated to be more accurate and
reflect the fact that they are probably not metrics you want to use.

BUG=625920, 638076
==========

[commit-bot: I haz the power, 2016-09-29 07:36:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-29 07:38:27]

Description was changed from

==========
Update descriptions and owners for permissions metrics.

Some of the descriptions have been updated to be more accurate and
reflect the fact that they are probably not metrics you want to use.

BUG=625920, 638076
==========

to

==========
Update descriptions and owners for permissions metrics.

Some of the descriptions have been updated to be more accurate and
reflect the fact that they are probably not metrics you want to use.

BUG=625920, 638076

Committed: https://crrev.com/f1f026f4dc5b30ceb5061a12057f32c56cc12a1e
Cr-Commit-Position: refs/heads/master@{#421770}
==========

[commit-bot: I haz the power, 2016-09-29 07:38:28]

Patchset 3 (id:??) landed as
https://crrev.com/f1f026f4dc5b30ceb5061a12057f32c56cc12a1e
Cr-Commit-Position: refs/heads/master@{#421770}