tools/metrics/histograms/histograms.xml - Issue 2369273002: Update descriptions and owners for permissions metrics.

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2369273002: Update descriptions and owners for permissions metrics. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 78740b931d6abe68c88fb1a254ccfa9abb1e29c1..4ac5d13c2afc07114701f8c39ba47918ae2621ca 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -6892,23 +6892,64 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</histogram>

+ <owner>kcarattini@chromium.org</owner>

+ <owner>dominickn@chromium.org</owner>

<owner>miguelg@chromium.org</owner>

- <summary>Number of times a given permission was requested.</summary>

+ <summary>

+ Number of times a given permission was requested by a website and the user

+ has the permission set to prompt (i.e. not blocked or allowed).

+ Note this is probably not the metric you want - it does not correspond to

+ the total number of times websites request a permission. Also, because

+ specific permissions have code that can automatically block or grant

+ permissions based on things like incognito, installed extensions etc., this

+ does also not correspond to the number of times users are prompted to allow

+ permissions.

+ For a better metric to track how often users are prompted, either use

+ ContentSettings.PermissionsActions*, or Permissions.Prompt.*.

+ </summary>

</histogram>

<histogram name="ContentSettings.PermissionRequested_InsecureOrigin"

enum="PermissionType">

+ <owner>kcarattini@chromium.org</owner>

+ <owner>dominickn@chromium.org</owner>

<owner>miguelg@chromium.org</owner>

- Number of times a given permission was requested from an insecure origin.

+ Number of times a given permission was requested by an insecure origin and

+ the user has the permission set to prompt (i.e. not blocked or allowed).

+ Note this is probably not the metric you want - it does not correspond to

+ the total number of times websites request a permission. Also, because

+ specific permissions have code that can automatically block or grant

+ permissions based on things like incognito, installed extensions etc., this

+ does also not correspond to the number of times users are prompted to allow

+ permissions.

+ For a better metric to track how often users are prompted, either use

+ ContentSettings.PermissionsActions*.

</summary>

</histogram>

<histogram name="ContentSettings.PermissionRequested_SecureOrigin"

enum="PermissionType">

+ <owner>kcarattini@chromium.org</owner>

+ <owner>dominickn@chromium.org</owner>

<owner>miguelg@chromium.org</owner>

- Number of times a given permission was requested from a secure origin.

+ Number of times a given permission was requested by a secure origin and the

+ user has the permission set to prompt (i.e. not blocked or allowed).

+ Note this is probably not the metric you want - it does not correspond to

+ the total number of times websites request a permission. Also, because

+ specific permissions have code that can automatically block or grant

+ permissions based on things like incognito, installed extensions etc., this

+ does also not correspond to the number of times users are prompted to allow

+ permissions.

+ For a better metric to track how often users are prompted, either use

+ ContentSettings.PermissionsActions*.

dominickn 2016/09/27 06:58:00 Missing end of sentence here?

benwells 2016/09/27 07:06:57 Done.

</summary>

</histogram>

@@ -41071,6 +41112,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</histogram>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

<owner>miguelg@chromium.org</owner>

<owner>mlamouri@chromium.org</owner>

@@ -41080,6 +41123,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</histogram>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

<owner>miguelg@chromium.org</owner>

<owner>mlamouri@chromium.org</owner>

@@ -41089,6 +41134,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</histogram>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

<owner>miguelg@chromium.org</owner>

<owner>mlamouri@chromium.org</owner>

@@ -41098,8 +41145,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</histogram>

- <owner>benwells@chromium.org</owner>

- <owner>tsergeant@chromium.org</owner>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

Tracks the permission bubbles (merged and non-merged) that are accepted.

Merged bubbles are considered accepted if all permissions are allowed.

@@ -41108,6 +41155,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

For each granted permission prompt displayed with a persistence toggle

(remember my decision), records whether the persistence toggle was enabled

@@ -41117,6 +41165,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

This metric, recorded at the time of a permission prompt accept, records the

total number of prompt dismissal events for this origin since the last time

@@ -41127,6 +41176,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

This metric, recorded at the time of a permission prompt accept, records the

total number of prompt ignore events for this origin since the last time the

@@ -41136,8 +41186,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</histogram>

- <owner>benwells@chromium.org</owner>

- <owner>tsergeant@chromium.org</owner>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

Tracks the permission bubbles (merged and non-merged) that are denied.

Merged bubbles are considered denied if any permission is denied.

@@ -41146,6 +41196,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

For each denied permission prompt displayed with a persistence toggle

(remember my decision), records whether the persistence toggle was enabled

@@ -41155,6 +41206,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

This metric, recorded at the time of a permission prompt deny, records the

total number of prompt dismissal events for this origin since the last time

@@ -41165,6 +41217,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

This metric, recorded at the time of a permission prompt deny, records the

total number of prompt ignore events for this origin since the last time the

@@ -41175,6 +41228,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

Renamed to Permissions.Prompt.Dismissed.PriorDismissCount on 17 August 2016.

</obsolete>

@@ -41190,6 +41244,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

This metric, recorded at the time of a permission prompt dismiss, records

the total number of prompt dismissal events for this origin since the last

@@ -41200,6 +41255,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

This metric, recorded at the time of a permission prompt dismiss, records

the total number of prompt ignore events for this origin since the last time

@@ -41210,6 +41266,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

Renamed to Permissions.Prompt.Dismissed.PriorDismissCount on 17 August 2016.

</obsolete>

@@ -41225,6 +41282,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

This metric, recorded at the time of a permission prompt ignore, records the

total number of prompt dismissal events for this origin since the last time

@@ -41235,6 +41293,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

This metric, recorded at the time of a permission prompt ignore, records the

total number of prompt ignore events for this origin since the last time the

@@ -41245,8 +41304,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram name="Permissions.Prompt.MergedBubbleAccepted"

enum="PermissionRequestType">

- <owner>benwells@chromium.org</owner>

- <owner>tsergeant@chromium.org</owner>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

Tracks acceptance of permission bubble request types that have been merged

into coalesced bubbles.

@@ -41255,8 +41314,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram name="Permissions.Prompt.MergedBubbleDenied"

enum="PermissionRequestType">

- <owner>benwells@chromium.org</owner>

- <owner>tsergeant@chromium.org</owner>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

Tracks denial of permission bubble request types that have been merged into

coalesced bubbles.

@@ -41265,8 +41324,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram name="Permissions.Prompt.MergedBubbleTypes"

enum="PermissionRequestType">

- <owner>benwells@chromium.org</owner>

- <owner>tsergeant@chromium.org</owner>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

Tracks the permission bubble request types that are being merged into

coalesced bubbles.

@@ -41274,8 +41333,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</histogram>

- <owner>benwells@chromium.org</owner>

- <owner>tsergeant@chromium.org</owner>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

How many permission requests each permissions prompt shown to the user

contains.

@@ -41283,29 +41342,53 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</histogram>

- <owner>benwells@chromium.org</owner>

- <owner>tsergeant@chromium.org</owner>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

Tracks how many times permission prompts are shown to users.

</summary>

</histogram>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

<owner>keenanb@google.com</owner>

<owner>jww@chromium.org</owner>

The embedder's permission setting at the time of a cross-origin iframe

permission request for a given permission type. See the corresponding

histogram suffixes.

+ A request is when a website makes a permission request and the user has the

+ permission set to prompt (i.e. not blocked or allowed).

+ Note this is probably not the metric you want - it does not correspond to

+ the total number of times websites request a permission. Also, because

+ specific permissions have code that can automatically block or grant

+ permissions based on things like incognito, installed extensions etc., this

+ does also not correspond to the number of times users are prompted to allow

+ permissions.

</summary>

</histogram>

+ <owner>dominickn@chromium.org</owner>

+ <owner>kcarattini@chromium.org</owner>

<owner>keenanb@google.com</owner>

<owner>jww@chromium.org</owner>

The permission type (geolocation, and such) of a same-origin permission

request.

+ A request is when a website makes a permission request and the user has the

+ permission set to prompt (i.e. not blocked or allowed).

+ Note this is probably not the metric you want - it does not correspond to

+ the total number of times websites request a permission. Also, because

+ specific permissions have code that can automatically block or grant

+ permissions based on things like incognito, installed extensions etc., this

+ does also not correspond to the number of times users are prompted to allow

+ permissions.

</summary>

</histogram>

« no previous file with comments | « no previous file | no next file » | no next file with comments »