Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2369113002: Revert "Apply first-line transform-text style" (Closed)

Created:
4 years, 2 months ago by rhogan
Modified:
4 years, 2 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Apply first-line transform-text style (patchset #1 id:1 of https://codereview.chromium.org/2339683004/ ) Reason for revert: This is still causing asan crashes. The crashes seem specific to cases where the transformed text is longer than the original text. I think the Iterator object is keeping a pointer to the text and the reallocation required fit the new text throws it out. Original issue's description: > Apply first-line transform-text style > > A third go at https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658 > > Although I still can't reproduce the clusterfuzz reports locally I'm confident > this will cure the specific crashes because I'm no longer transforming the > first line's text unless it has a distinct first-line style (:/). > > BUG=129669, 644733 > > Committed: https://crrev.com/e17f77cab60f321629c438796cc14fae3f2fa7dc > Cr-Commit-Position: refs/heads/master@{#418840} TBR=eae@chromium.org BUG=129669, 644733, 649810 Committed: https://crrev.com/d20ce6090a7fd879d433d9d8df0e50100914352b Cr-Commit-Position: refs/heads/master@{#420988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -78 lines) Patch
D third_party/WebKit/LayoutTests/fast/text/transform-text-first-line.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/text/transform-text-first-line-capitalize.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/text/transform-text-first-line-capitalize-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/text/transform-text-first-line-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/text/transform-text-first-line-lowercase.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/text/transform-text-first-line-lowercase-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutText.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369113002/1
4 years, 2 months ago (2016-09-26 18:07:20 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286341)
4 years, 2 months ago (2016-09-26 19:09:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369113002/1
4 years, 2 months ago (2016-09-26 19:16:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 20:59:37 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 21:01:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d20ce6090a7fd879d433d9d8df0e50100914352b
Cr-Commit-Position: refs/heads/master@{#420988}

Powered by Google App Engine
This is Rietveld 408576698