DescriptionRevert of Apply first-line transform-text style (patchset #1 id:1 of https://codereview.chromium.org/2339683004/ )
Reason for revert:
This is still causing asan crashes. The crashes seem specific to cases where the transformed text is longer than the original text. I think the Iterator object is keeping a pointer to the text and the reallocation required fit the new text throws it out.
Original issue's description:
> Apply first-line transform-text style
>
> A third go at https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658
>
> Although I still can't reproduce the clusterfuzz reports locally I'm confident
> this will cure the specific crashes because I'm no longer transforming the
> first line's text unless it has a distinct first-line style (:/).
>
> BUG=129669, 644733
>
> Committed: https://crrev.com/e17f77cab60f321629c438796cc14fae3f2fa7dc
> Cr-Commit-Position: refs/heads/master@{#418840}
TBR=eae@chromium.org
BUG=129669, 644733, 649810
Committed: https://crrev.com/d20ce6090a7fd879d433d9d8df0e50100914352b
Cr-Commit-Position: refs/heads/master@{#420988}
Patch Set 1 #Messages
Total messages: 10 (5 generated)
|