Apply first-line transform-text style

Apply first-line transform-text style

A third go at https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658

Although I still can't reproduce the clusterfuzz reports locally I'm confident
this will cure the specific crashes because I'm no longer transforming the
first line's text unless it has a distinct first-line style (:/).

BUG=129669, 644733
Committed: https://crrev.com/e17f77cab60f321629c438796cc14fae3f2fa7dc
Cr-Commit-Position: refs/heads/master@{#418840}

[rhogan, 2016-09-14 20:12:40]

Description was changed from

==========
Apply first-line transform-text style

BUG=129669
==========

to

==========
Apply first-line transform-text style

A third go at https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658

Although I still can't reproduce the clusterfuzz reports locally I'm confident
this will cure the specific crashes because I'm no longer transforming the
first line's text unless it has a distinct first-line style (:/).

BUG=129669,644733
==========

[rhogan, 2016-09-14 20:12:41]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org

[rhogan, 2016-09-14 20:13:20]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 20:13:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 00:37:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:37:45]

Dry run: This issue passed the CQ dry run.

[eae, 2016-09-15 09:22:23]

LGTM

[rhogan, 2016-09-15 10:24:06]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-09-15 10:24:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 10:24:23]

This CL has an open dependency (Issue 2326303002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[rhogan, 2016-09-15 12:02:48]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-09-15 12:03:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 12:07:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 12:09:36]

Description was changed from

==========
Apply first-line transform-text style

A third go at https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658

Although I still can't reproduce the clusterfuzz reports locally I'm confident
this will cure the specific crashes because I'm no longer transforming the
first line's text unless it has a distinct first-line style (:/).

BUG=129669,644733
==========

to

==========
Apply first-line transform-text style

A third go at https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658

Although I still can't reproduce the clusterfuzz reports locally I'm confident
this will cure the specific crashes because I'm no longer transforming the
first line's text unless it has a distinct first-line style (:/).

BUG=129669,644733

Committed: https://crrev.com/e17f77cab60f321629c438796cc14fae3f2fa7dc
Cr-Commit-Position: refs/heads/master@{#418840}
==========

[commit-bot: I haz the power, 2016-09-15 12:09:37]

Patchset 1 (id:??) landed as
https://crrev.com/e17f77cab60f321629c438796cc14fae3f2fa7dc
Cr-Commit-Position: refs/heads/master@{#418840}

[rhogan, 2016-09-25 11:14:39]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2366173002/ by robhogan@gmail.com.

The reason for reverting is: This is still causing asan crashes. The crashes
seem specific to cases where the transformed text is longer than the original
text. I think the Iterator object is keeping a pointer to the text and the
reallocation required fit the new text throws it out. .

[rhogan, 2016-09-26 17:58:01]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2368383002/ by robhogan@gmail.com.

The reason for reverting is: This is still causing asan crashes. The crashes
seem specific to cases where the transformed text is longer than the original
text. I think the Iterator object is keeping a pointer to the text and the
reallocation required fit the new text throws it out. .