Source/web/WebViewImpl.cpp - Issue 23691017: [Android WebView] Treat zero values in viewport arguments specially

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 23691017: [Android WebView] Treat zero values in viewport arguments specially (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 1e5aa3af58a2902e3ace01f86a5140ad362ea37b..f687b005b332cf6ce95f17225d90580e46b65105 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -3015,8 +3015,8 @@ void WebViewImpl::updatePageDefinedPageScaleConstraints(const ViewportArguments&

return;

ViewportArguments adjustedArguments = arguments;

- if (settingsImpl()->viewportMetaLayoutSizeQuirk() && adjustedArguments.type == ViewportArguments::ViewportMeta)

- adjustedArguments.type = ViewportArguments::ViewportMetaLayoutSizeQuirk;

+ if (settingsImpl()->viewportMetaLayoutSizeAndZeroValuesQuirk() && adjustedArguments.type == ViewportArguments::ViewportMeta)

+ adjustedArguments.type = ViewportArguments::ViewportMetaLayoutSizeAndZeroValuesQuirk;

m_pageScaleConstraintsSet.updatePageDefinedConstraints(adjustedArguments, m_size, page()->settings().layoutFallbackWidth());

if (settingsImpl()->supportDeprecatedTargetDensityDPI())