Source/web/WebSettingsImpl.h - Issue 23691017: [Android WebView] Treat zero values in viewport arguments specially

Unified Diff: Source/web/WebSettingsImpl.h

Issue 23691017: [Android WebView] Treat zero values in viewport arguments specially (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebSettingsImpl.h

diff --git a/Source/web/WebSettingsImpl.h b/Source/web/WebSettingsImpl.h

index 0206df9301a100e08cfce56b5bdbdab8cd0c8e8c..c1ab62a4b293ba75cd57fccab4597eae19c9eea1 100644

--- a/Source/web/WebSettingsImpl.h

+++ b/Source/web/WebSettingsImpl.h

@@ -165,7 +165,7 @@ public:

virtual void setUseWideViewport(bool);

virtual void setValidationMessageTimerMagnification(int);

virtual void setViewportEnabled(bool);

- virtual void setViewportMetaLayoutSizeQuirk(bool);

+ virtual void setViewportMetaLayoutSizeAndZeroValuesQuirk(bool);

virtual void setVisualWordMovementEnabled(bool);

virtual void setWebAudioEnabled(bool);

virtual void setWebGLErrorsToConsoleEnabled(bool);

@@ -180,7 +180,7 @@ public:

bool doubleTapToZoomEnabled() const { return m_doubleTapToZoomEnabled; }

bool perTilePaintingEnabled() const { return m_perTilePaintingEnabled; }

bool supportDeprecatedTargetDensityDPI() const { return m_supportDeprecatedTargetDensityDPI; }

- bool viewportMetaLayoutSizeQuirk() const { return m_viewportMetaLayoutSizeQuirk; }

+ bool viewportMetaLayoutSizeAndZeroValuesQuirk() const { return m_viewportMetaLayoutSizeAndZeroValuesQuirk; }

int pinchOverlayScrollbarThickness() const { return m_pinchOverlayScrollbarThickness; }

private:

@@ -196,8 +196,9 @@ private:

bool m_supportDeprecatedTargetDensityDPI;

// This quirk is to maintain compatibility with Android apps built on

// the Android SDK prior to and including version 18. Presumably, this

- // can be removed any time after 2015. See http://crbug.com/277369.

- bool m_viewportMetaLayoutSizeQuirk;

+ // can be removed any time after 2015.

+ // See http://crbug.com/277369 and http://crbug.com/282130.

rune 2013/09/02 06:25:14 These bugs are not accessible to me. I guess that

kenneth.r.christiansen 2013/09/02 06:45:04 Same to me... forbidden

mnaganov (inactive) 2013/09/02 13:25:53 Sorry for that. Basically, http://crbug.com/277369

+ bool m_viewportMetaLayoutSizeAndZeroValuesQuirk;

int m_pinchOverlayScrollbarThickness;

};