Remove decision by Turbofan OSR to optimize on next call

Remove decision by Turbofan OSR to optimize on next call

When we OSR using Turbofan, we would set the function to be optimized
on the next call, irrespective of the runtime profiler's previous
decisions - such as compiling for baseline. It seems more prudent to
always make these decisions in the runtime profiler where the data is
available.

Committed: https://crrev.com/0d1e15d6e562380549bf7a56032db153f0060948
Cr-Commit-Position: refs/heads/master@{#39782}

[klaasb, 2016-09-26 15:24:23]

klaasb@google.com changed reviewers:
+ mstarzinger@chromium.org, mythria@chromium.org, rmcilroy@chromium.org

[rmcilroy, 2016-09-26 15:45:28]

LGTM, but I'd like Michi to comment.

[Michael Starzinger, 2016-09-26 16:02:43]

mstarzinger@chromium.org changed reviewers:
+ titzer@chromium.org

[Michael Starzinger, 2016-09-26 16:02:44]

LGTM from my end.
+Ben: Just FYI.

[klaasb, 2016-09-26 16:24:48]

The CQ bit was checked by klaasb@google.com

[commit-bot: I haz the power, 2016-09-26 16:24:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-09-26 16:36:50]

On 2016/09/26 16:24:50, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

The intent of the original heuristic was to avoid repeatedly OSRing the same
function because (one of) the side effects of optimizing a function was clearing
its tick count.
But we never verified was useful in practice, so it seems reasonable to remove
that complexity.

[commit-bot: I haz the power, 2016-09-26 16:43:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 16:43:15]

Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/15054)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[klaasb, 2016-09-27 14:04:09]

The CQ bit was checked by klaasb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 14:04:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[klaasb, 2016-09-27 14:04:37]

Hi Ross,

PTAL. Fixed the TickLinesBaseline test by setting --no-crankshaft and removing
the call to NeverOptimizeFunction.

[klaasb, 2016-09-27 14:04:37]

Hi Ross,

PTAL. Fixed the TickLinesBaseline test by setting --no-crankshaft and removing
the call to NeverOptimizeFunction.

[commit-bot: I haz the power, 2016-09-27 14:28:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 14:28:13]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-09-27 15:27:46]

LGTM with a nit.

https://codereview.chromium.org/2369043002/diff/20001/test/cctest/test-cpu-pr...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/2369043002/diff/20001/test/cctest/test-cpu-pr...
test/cctest/test-cpu-profiler.cc:1039: i::FLAG_crankshaft = false;
Could you just do this at the start of TickLinesBaseline instead (so that it is
set correctly before"CcTest::InitializeVM();"

[klaasb, 2016-09-27 15:54:40]

https://codereview.chromium.org/2369043002/diff/20001/test/cctest/test-cpu-pr...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/2369043002/diff/20001/test/cctest/test-cpu-pr...
test/cctest/test-cpu-profiler.cc:1039: i::FLAG_crankshaft = false;
On 2016/09/27 15:27:45, rmcilroy wrote:
> Could you just do this at the start of TickLinesBaseline instead (so that it
is
> set correctly before"CcTest::InitializeVM();"

Done.

[klaasb, 2016-09-27 15:54:49]

The CQ bit was checked by klaasb@google.com

[klaasb, 2016-09-27 15:54:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2369043002/#ps40001
(title: "comment from Ross")

[commit-bot: I haz the power, 2016-09-27 15:55:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 16:27:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 16:27:50]

Description was changed from

==========
Remove decision by Turbofan OSR to optimize on next call

When we OSR using Turbofan, we would set the function to be optimized
on the next call, irrespective of the runtime profiler's previous
decisions - such as compiling for baseline. It seems more prudent to
always make these decisions in the runtime profiler where the data is
available.
==========

to

==========
Remove decision by Turbofan OSR to optimize on next call

When we OSR using Turbofan, we would set the function to be optimized
on the next call, irrespective of the runtime profiler's previous
decisions - such as compiling for baseline. It seems more prudent to
always make these decisions in the runtime profiler where the data is
available.

Committed: https://crrev.com/0d1e15d6e562380549bf7a56032db153f0060948
Cr-Commit-Position: refs/heads/master@{#39782}
==========

[commit-bot: I haz the power, 2016-09-27 16:27:51]

Patchset 3 (id:??) landed as
https://crrev.com/0d1e15d6e562380549bf7a56032db153f0060948
Cr-Commit-Position: refs/heads/master@{#39782}

[klaasb, 2016-09-27 16:41:38]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2370083003/ by klaasb@google.com.

The reason for reverting is: Breaks build because of empty printf format
string..