Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2369013006: Update vulkan varying locations to correctly handle arrays (Closed)

Created:
4 years, 2 months ago by egdaniel
Modified:
4 years, 2 months ago
Reviewers:
ethannicholas
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update vulkan varying locations to correctly handle arrays BUG=skia:5797 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369013006 Committed: https://skia.googlesource.com/skia/+/5b20c463a3e0cd0e101acfb77608cab8532717f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
M src/gpu/vk/GrVkVaryingHandler.cpp View 1 chunk +59 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
egdaniel
This changed is based off of section 14.1.4 of the vulkan spec.
4 years, 2 months ago (2016-09-27 15:43:42 UTC) #3
ethannicholas
lgtm
4 years, 2 months ago (2016-09-27 15:48:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369013006/1
4 years, 2 months ago (2016-09-27 15:50:18 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 16:09:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5b20c463a3e0cd0e101acfb77608cab8532717f2

Powered by Google App Engine
This is Rietveld 408576698