Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 23690003: Revert "Add Chromium-style TimeDelta, Time and TimeTicks classes, and a new ElapsedTimer class." (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Revert "Add Chromium-style TimeDelta, Time and TimeTicks classes, and a new ElapsedTimer class." This reverts commit r16390 for breaking the Windows build. Will reland fixed version, which also uses the platform/ folder instead of time/ folder as per offline discussion. TBR=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -1256 lines) Patch
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.h View 5 chunks +13 lines, -13 lines 0 comments Download
M src/compiler.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M src/counters.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/counters.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/cpu-profiler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cpu-profiler.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/hydrogen.h View 1 chunk +15 lines, -11 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M src/lithium-allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/log.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/log.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M src/optimizing-compiler-thread.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M src/parser.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M src/platform.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-openbsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-posix.cc View 1 chunk +13 lines, -1 line 0 comments Download
M src/platform-win32.cc View 11 chunks +105 lines, -21 lines 0 comments Download
M src/profile-generator.h View 3 chunks +4 lines, -6 lines 0 comments Download
M src/profile-generator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D src/time/elapsed-timer.h View 1 chunk +0 lines, -120 lines 0 comments Download
D src/time/time.h View 1 chunk +0 lines, -381 lines 0 comments Download
D src/time/time.cc View 1 chunk +0 lines, -483 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 5 chunks +11 lines, -9 lines 0 comments Download
D test/cctest/test-time.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M tools/gyp/v8.gyp View 6 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Benedikt Meurer
Committed patchset #1 manually as r16391.
7 years, 3 months ago (2013-08-28 11:38:48 UTC) #1
Michael Achenbach
7 years, 3 months ago (2013-08-28 11:40:03 UTC) #2
Message was sent while issue was closed.
On 2013/08/28 11:38:48, Benedikt Meurer wrote:
> Committed patchset #1 manually as r16391.

lgtm

Powered by Google App Engine
This is Rietveld 408576698