PPC/s390: [sysroot installer] Disable for host arch PPC/s390

PPC/s390: [sysroot installer] Disable for host arch PPC/s390

Since PPC/s390 doesn't have the sysroot files available
on google storage, disabling it so that the script doesn't
cause gclient sync to fail when run on PPC/s390.

R=agrieve@chromium.org

BUG=
LOG=N

Committed: https://crrev.com/5e5689bba0a51bad28c08bf3a3820da57a185c3b
Cr-Commit-Position: refs/heads/master@{#421722}

[JaideepBajwa, 2016-09-27 14:52:31]

PTAL

[agrieve, 2016-09-27 15:09:54]

lgtm

[JaideepBajwa, 2016-09-27 15:12:03]

The CQ bit was checked by bjaideep@ca.ibm.com

[commit-bot: I haz the power, 2016-09-27 15:12:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 15:19:00]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[JaideepBajwa, 2016-09-27 15:35:55]

On 2016/09/27 15:19:00, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

The failure doesn't seem to be from my change. Looks like DetectHostArch()
doesn't have the case to handle "AMD64". Should I add a case for it? Something
like:
elif detected_host_arch == 'AMD64':
    return 'amd64'

[JaideepBajwa, 2016-09-28 17:48:34]

The CQ bit was checked by bjaideep@ca.ibm.com

[commit-bot: I haz the power, 2016-09-28 17:49:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 17:59:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 17:59:23]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[JaideepBajwa, 2016-09-28 20:47:23]

The CQ bit was checked by bjaideep@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 20:47:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 20:56:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 20:56:44]

Dry run: This issue passed the CQ dry run.

[JaideepBajwa, 2016-09-28 21:06:15]

On 2016/09/28 17:59:23, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

PTAL, I added "AMD64" to HostArch method. Dry run looks good.

[agrieve, 2016-09-29 00:06:36]

On 2016/09/28 21:06:15, JaideepBajwa wrote:
> On 2016/09/28 17:59:23, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
> 
> PTAL, I added "AMD64" to HostArch method. Dry run looks good.

lgtm

[JaideepBajwa, 2016-09-29 02:31:40]

The CQ bit was checked by bjaideep@ca.ibm.com

[commit-bot: I haz the power, 2016-09-29 02:31:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[JaideepBajwa, 2016-09-29 02:31:58]

On 2016/09/29 00:06:36, agrieve wrote:
> On 2016/09/28 21:06:15, JaideepBajwa wrote:
> > On 2016/09/28 17:59:23, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
> > 
> > PTAL, I added "AMD64" to HostArch method. Dry run looks good.
> 
> lgtm

Thank you.

[commit-bot: I haz the power, 2016-09-29 02:36:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-29 02:38:29]

Description was changed from

==========
PPC/s390: [sysroot installer] Disable for host arch PPC/s390

Since PPC/s390 doesn't have the sysroot files available
on google storage, disabling it so that the script doesn't
cause gclient sync to fail when run on PPC/s390.

R=agrieve@chromium.org

BUG=
LOG=N
==========

to

==========
PPC/s390: [sysroot installer] Disable for host arch PPC/s390

Since PPC/s390 doesn't have the sysroot files available
on google storage, disabling it so that the script doesn't
cause gclient sync to fail when run on PPC/s390.

R=agrieve@chromium.org

BUG=
LOG=N

Committed: https://crrev.com/5e5689bba0a51bad28c08bf3a3820da57a185c3b
Cr-Commit-Position: refs/heads/master@{#421722}
==========

[commit-bot: I haz the power, 2016-09-29 02:38:30]

Patchset 3 (id:??) landed as
https://crrev.com/5e5689bba0a51bad28c08bf3a3820da57a185c3b
Cr-Commit-Position: refs/heads/master@{#421722}

[tsergeant, 2016-09-29 03:26:10]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2376253002/ by tsergeant@chromium.org.

The reason for reverting is: This causes failures in gclient runhooks on 32 bit
machines:

https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/bu...

Log snippet:

running 'E:\b\depot_tools\python276_bin\python.exe
src/build/linux/sysroot_scripts/install-sysroot.py
Unrecognized host arch: x86.

[JaideepBajwa, 2016-09-29 19:59:34]

On 2016/09/29 03:26:10, tsergeant wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2376253002/ by mailto:tsergeant@chromium.org.
> 
> The reason for reverting is: This causes failures in gclient runhooks on 32
bit
> machines:
> 
>
https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/bu...
> 
> Log snippet:
> 
> running 'E:\b\depot_tools\python276_bin\python.exe
> src/build/linux/sysroot_scripts/install-sysroot.py
> Unrecognized host arch: x86.

hmm, it should be failing regardless of my changes since my changes are only
adding a few conditions for ppc and s390.
@agrieve, is there anything I'm missing?

[agrieve, 2016-09-29 20:37:40]

On 2016/09/29 19:59:34, JaideepBajwa wrote:
> On 2016/09/29 03:26:10, tsergeant wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
> > https://codereview.chromium.org/2376253002/ by
mailto:tsergeant@chromium.org.
> > 
> > The reason for reverting is: This causes failures in gclient runhooks on 32
> bit
> > machines:
> > 
> >
>
https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/bu...
> > 
> > Log snippet:
> > 
> > running 'E:\b\depot_tools\python276_bin\python.exe
> > src/build/linux/sysroot_scripts/install-sysroot.py
> > Unrecognized host arch: x86.
> 
> hmm, it should be failing regardless of my changes since my changes are only
> adding a few conditions for ppc and s390.
> @agrieve, is there anything I'm missing?

I can't figure how this could have caused it to fail either :(. Quite clear that
the bot went red, and then the revert made it go green though. Mystery!

[JaideepBajwa, 2016-09-29 21:03:11]

On 2016/09/29 20:37:40, agrieve wrote:
> On 2016/09/29 19:59:34, JaideepBajwa wrote:
> > On 2016/09/29 03:26:10, tsergeant wrote:
> > > A revert of this CL (patchset #3 id:40001) has been created in
> > > https://codereview.chromium.org/2376253002/ by
> mailto:tsergeant@chromium.org.
> > > 
> > > The reason for reverting is: This causes failures in gclient runhooks on
32
> > bit
> > > machines:
> > > 
> > >
> >
>
https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/bu...
> > > 
> > > Log snippet:
> > > 
> > > running 'E:\b\depot_tools\python276_bin\python.exe
> > > src/build/linux/sysroot_scripts/install-sysroot.py
> > > Unrecognized host arch: x86.
> > 
> > hmm, it should be failing regardless of my changes since my changes are only
> > adding a few conditions for ppc and s390.
> > @agrieve, is there anything I'm missing?
> 
> I can't figure how this could have caused it to fail either :(. Quite clear
that
> the bot went red, and then the revert made it go green though. Mystery!

I could possibly update the condition for ia32? something like:
if re.match(r'i.86', host_arch) or host_arch in ['i86pc', 'x86']:
   host_arch = 'ia32'

[JaideepBajwa, 2016-09-29 22:10:02]

On 2016/09/29 21:03:11, JaideepBajwa wrote:
> On 2016/09/29 20:37:40, agrieve wrote:
> > On 2016/09/29 19:59:34, JaideepBajwa wrote:
> > > On 2016/09/29 03:26:10, tsergeant wrote:
> > > > A revert of this CL (patchset #3 id:40001) has been created in
> > > > https://codereview.chromium.org/2376253002/ by
> > mailto:tsergeant@chromium.org.
> > > > 
> > > > The reason for reverting is: This causes failures in gclient runhooks on
> 32
> > > bit
> > > > machines:
> > > > 
> > > >
> > >
> >
>
https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/bu...
> > > > 
> > > > Log snippet:
> > > > 
> > > > running 'E:\b\depot_tools\python276_bin\python.exe
> > > > src/build/linux/sysroot_scripts/install-sysroot.py
> > > > Unrecognized host arch: x86.
> > > 
> > > hmm, it should be failing regardless of my changes since my changes are
only
> > > adding a few conditions for ppc and s390.
> > > @agrieve, is there anything I'm missing?
> > 
> > I can't figure how this could have caused it to fail either :(. Quite clear
> that
> > the bot went red, and then the revert made it go green though. Mystery!
> 
> I could possibly update the condition for ia32? something like:
> if re.match(r'i.86', host_arch) or host_arch in ['i86pc', 'x86']:
>    host_arch = 'ia32'

I think I found the issue, I'm calling DetectHostArch() even when its not need
to be called. x86 and AMD64 probably pass the host arch option. I've uploaded
another CL with this update. Should work this time.
https://codereview.chromium.org/2382883003