Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2382883003: PPC/s390: [sysroot installer] Disable for host arch PPC/s390 (Closed)

Created:
4 years, 2 months ago by JaideepBajwa
Modified:
4 years, 2 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PPC/s390: [sysroot installer] Disable for host arch PPC/s390 Since PPC/s390 doesn't have the sysroot files available on google storage, disabling it so that the script doesn't cause gclient sync to fail when run on PPC/s390. R=agrieve@chromium.org BUG= LOG=N Committed: https://crrev.com/d572de4bd07f6018017e705d4dd024d4b0ad82ad Cr-Commit-Position: refs/heads/master@{#422014}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M AUTHORS View 2 chunks +2 lines, -0 lines 0 comments Download
M build/detect_host_arch.py View 1 chunk +5 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 1 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
JaideepBajwa
PTAL
4 years, 2 months ago (2016-09-29 22:10:15 UTC) #1
agrieve
lgtm https://codereview.chromium.org/2382883003/diff/1/build/linux/sysroot_scripts/install-sysroot.py File build/linux/sysroot_scripts/install-sysroot.py (right): https://codereview.chromium.org/2382883003/diff/1/build/linux/sysroot_scripts/install-sysroot.py#newcode192 build/linux/sysroot_scripts/install-sysroot.py:192: InstallDefaultSysroots() nit: can you change this so that ...
4 years, 2 months ago (2016-09-29 23:59:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382883003/20001
4 years, 2 months ago (2016-09-30 02:01:26 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 02:08:10 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 02:15:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d572de4bd07f6018017e705d4dd024d4b0ad82ad
Cr-Commit-Position: refs/heads/master@{#422014}

Powered by Google App Engine
This is Rietveld 408576698