Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2368913003: Populate storage_unittests target. (Closed)

Created:
4 years, 2 months ago by pwnall
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, wjmaclean, kinuko+watch, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, jkarlin+watch_chromium.org, cmumford, shimazu+serviceworker_chromium.org, horo+watch_chromium.org, dcheng, jsbell+idb_chromium.org, kinuko+fileapi, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Populate storage_unittests target. The unit tests for storage/browser/ currently live under content/browser/. This change moves them under the newly created storage_unittests target, so the _unittest.cc files can live next to the files that they test. BUG=

Patch Set 1 #

Patch Set 2 : Removed unused includes. #

Patch Set 3 : Moved storage test helpers from content/public/test/ to storage/browser/test/ #

Patch Set 4 : Removed unnecessary include from storage/browser/blob/blob_storage_context_unittest.cc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -25322 lines) Patch
M chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/engagement/site_engagement_eviction_policy_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_data_migrator_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/mock_extension_special_storage_policy.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/quota_policy_channel_id_store_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/platform_util_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/appcache/appcache_storage_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/chrome_appcache_service_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D content/browser/blob_storage/blob_async_builder_host_unittest.cc View 1 2 3 1 chunk +0 lines, -617 lines 0 comments Download
D content/browser/blob_storage/blob_async_transport_request_builder_unittest.cc View 1 2 3 1 chunk +0 lines, -356 lines 0 comments Download
M content/browser/blob_storage/blob_dispatcher_host_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D content/browser/blob_storage/blob_reader_unittest.cc View 1 2 3 1 chunk +0 lines, -1225 lines 0 comments Download
D content/browser/blob_storage/blob_storage_context_unittest.cc View 1 2 3 1 chunk +0 lines, -499 lines 0 comments Download
D content/browser/blob_storage/blob_storage_registry_unittest.cc View 1 2 3 1 chunk +0 lines, -84 lines 0 comments Download
D content/browser/blob_storage/blob_url_request_job_unittest.cc View 1 2 3 1 chunk +0 lines, -606 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/cache_storage/cache_storage_manager_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/database_tracker_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D content/browser/fileapi/copy_or_move_file_validator_unittest.cc View 1 2 3 1 chunk +0 lines, -336 lines 0 comments Download
D content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 1 2 3 1 chunk +0 lines, -877 lines 0 comments Download
D content/browser/fileapi/dragged_file_util_unittest.cc View 1 2 3 1 chunk +0 lines, -554 lines 0 comments Download
D content/browser/fileapi/external_mount_points_unittest.cc View 1 2 3 1 chunk +0 lines, -505 lines 0 comments Download
D content/browser/fileapi/file_system_context_unittest.cc View 1 2 3 1 chunk +0 lines, -391 lines 0 comments Download
D content/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 2 3 1 chunk +0 lines, -464 lines 0 comments Download
D content/browser/fileapi/file_system_file_stream_reader_unittest.cc View 1 2 3 1 chunk +0 lines, -274 lines 0 comments Download
D content/browser/fileapi/file_system_operation_impl_unittest.cc View 1 2 3 1 chunk +0 lines, -1312 lines 0 comments Download
D content/browser/fileapi/file_system_operation_impl_write_unittest.cc View 1 2 3 1 chunk +0 lines, -334 lines 0 comments Download
D content/browser/fileapi/file_system_operation_runner_unittest.cc View 1 2 3 1 chunk +0 lines, -250 lines 0 comments Download
D content/browser/fileapi/file_system_quota_client_unittest.cc View 1 2 3 1 chunk +0 lines, -571 lines 0 comments Download
D content/browser/fileapi/file_system_url_request_job_unittest.cc View 1 2 3 1 chunk +0 lines, -486 lines 0 comments Download
D content/browser/fileapi/file_system_url_unittest.cc View 1 2 3 1 chunk +0 lines, -224 lines 0 comments Download
D content/browser/fileapi/file_system_usage_cache_unittest.cc View 1 2 3 1 chunk +0 lines, -163 lines 0 comments Download
D content/browser/fileapi/file_writer_delegate_unittest.cc View 1 2 3 1 chunk +0 lines, -509 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D content/browser/fileapi/isolated_context_unittest.cc View 1 2 3 1 chunk +0 lines, -363 lines 0 comments Download
D content/browser/fileapi/local_file_stream_reader_unittest.cc View 1 2 3 1 chunk +0 lines, -283 lines 0 comments Download
D content/browser/fileapi/local_file_stream_writer_unittest.cc View 1 2 3 1 chunk +0 lines, -182 lines 0 comments Download
D content/browser/fileapi/local_file_util_unittest.cc View 1 2 3 1 chunk +0 lines, -381 lines 0 comments Download
D content/browser/fileapi/mock_file_change_observer.h View 1 2 3 1 chunk +0 lines, -103 lines 0 comments Download
D content/browser/fileapi/mock_file_change_observer.cc View 1 2 3 1 chunk +0 lines, -53 lines 0 comments Download
D content/browser/fileapi/mock_file_update_observer.h View 1 2 3 1 chunk +0 lines, -52 lines 0 comments Download
D content/browser/fileapi/mock_file_update_observer.cc View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/fileapi/mock_url_request_delegate.h View 1 2 3 1 chunk +0 lines, -40 lines 0 comments Download
D content/browser/fileapi/mock_url_request_delegate.cc View 1 2 3 1 chunk +0 lines, -75 lines 0 comments Download
D content/browser/fileapi/native_file_util_unittest.cc View 1 2 3 1 chunk +0 lines, -409 lines 0 comments Download
D content/browser/fileapi/obfuscated_file_util_unittest.cc View 1 2 3 1 chunk +0 lines, -2576 lines 0 comments Download
D content/browser/fileapi/plugin_private_file_system_backend_unittest.cc View 1 2 3 1 chunk +0 lines, -288 lines 0 comments Download
D content/browser/fileapi/recursive_operation_delegate_unittest.cc View 1 2 3 1 chunk +0 lines, -388 lines 0 comments Download
D content/browser/fileapi/sandbox_database_test_helper.h View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
D content/browser/fileapi/sandbox_database_test_helper.cc View 1 2 3 1 chunk +0 lines, -96 lines 0 comments Download
D content/browser/fileapi/sandbox_directory_database_unittest.cc View 1 2 3 1 chunk +0 lines, -677 lines 0 comments Download
D content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc View 1 2 3 1 chunk +0 lines, -87 lines 0 comments Download
D content/browser/fileapi/sandbox_file_system_backend_unittest.cc View 1 2 3 1 chunk +0 lines, -310 lines 0 comments Download
D content/browser/fileapi/sandbox_isolated_origin_database_unittest.cc View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/fileapi/sandbox_origin_database_unittest.cc View 1 2 3 1 chunk +0 lines, -309 lines 0 comments Download
D content/browser/fileapi/sandbox_prioritized_origin_database_unittest.cc View 1 2 3 1 chunk +0 lines, -216 lines 0 comments Download
D content/browser/fileapi/timed_task_helper_unittest.cc View 1 2 3 1 chunk +0 lines, -86 lines 0 comments Download
D content/browser/fileapi/transient_file_util_unittest.cc View 1 2 3 1 chunk +0 lines, -122 lines 0 comments Download
M content/browser/fileapi/upload_file_system_file_element_reader_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/net/quota_policy_cookie_store_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D content/browser/quota/mock_quota_manager.h View 1 2 3 1 chunk +0 lines, -154 lines 0 comments Download
D content/browser/quota/mock_quota_manager.cc View 1 2 3 1 chunk +0 lines, -151 lines 0 comments Download
D content/browser/quota/mock_quota_manager_proxy.h View 1 2 3 1 chunk +0 lines, -90 lines 0 comments Download
D content/browser/quota/mock_quota_manager_proxy.cc View 1 2 3 1 chunk +0 lines, -72 lines 0 comments Download
D content/browser/quota/mock_quota_manager_unittest.cc View 1 2 3 1 chunk +0 lines, -227 lines 0 comments Download
D content/browser/quota/quota_backend_impl_unittest.cc View 1 2 3 1 chunk +0 lines, -276 lines 0 comments Download
D content/browser/quota/quota_database_unittest.cc View 1 2 3 1 chunk +0 lines, -698 lines 0 comments Download
D content/browser/quota/quota_manager_unittest.cc View 1 2 3 1 chunk +0 lines, -2311 lines 0 comments Download
D content/browser/quota/quota_reservation_manager_unittest.cc View 1 2 3 1 chunk +0 lines, -372 lines 0 comments Download
M content/browser/quota/quota_temporary_storage_evictor_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D content/browser/quota/storage_monitor_unittest.cc View 1 2 3 1 chunk +0 lines, -703 lines 0 comments Download
D content/browser/quota/usage_tracker_unittest.cc View 1 2 3 1 chunk +0 lines, -338 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D content/public/test/async_file_test_helper.h View 1 2 3 1 chunk +0 lines, -114 lines 0 comments Download
D content/public/test/async_file_test_helper.cc View 1 2 3 1 chunk +0 lines, -272 lines 0 comments Download
D content/public/test/mock_blob_url_request_context.h View 1 2 3 1 chunk +0 lines, -61 lines 0 comments Download
D content/public/test/mock_blob_url_request_context.cc View 1 2 3 1 chunk +0 lines, -51 lines 0 comments Download
D content/public/test/mock_special_storage_policy.h View 1 2 3 1 chunk +0 lines, -104 lines 0 comments Download
D content/public/test/mock_special_storage_policy.cc View 1 2 3 1 chunk +0 lines, -47 lines 0 comments Download
D content/public/test/mock_storage_client.h View 1 2 3 1 chunk +0 lines, -109 lines 0 comments Download
D content/public/test/mock_storage_client.cc View 1 2 3 1 chunk +0 lines, -191 lines 0 comments Download
D content/public/test/sandbox_file_system_test_helper.h View 1 2 3 1 chunk +0 lines, -108 lines 0 comments Download
D content/public/test/sandbox_file_system_test_helper.cc View 1 2 3 1 chunk +0 lines, -166 lines 0 comments Download
D content/public/test/test_file_system_backend.h View 1 2 3 1 chunk +0 lines, -111 lines 0 comments Download
D content/public/test/test_file_system_backend.cc View 1 2 3 1 chunk +0 lines, -247 lines 0 comments Download
D content/public/test/test_file_system_context.h View 1 2 3 1 chunk +0 lines, -47 lines 0 comments Download
D content/public/test/test_file_system_context.cc View 1 2 3 1 chunk +0 lines, -73 lines 0 comments Download
D content/public/test/test_file_system_options.h View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
D content/public/test/test_file_system_options.cc View 1 2 3 1 chunk +0 lines, -46 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 9 chunks +1 line, -74 lines 0 comments Download
D content/test/fileapi_test_file_set.h View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
D content/test/fileapi_test_file_set.cc View 1 2 3 1 chunk +0 lines, -71 lines 0 comments Download
M storage/browser/BUILD.gn View 1 2 3 2 chunks +109 lines, -1 line 0 comments Download
A + storage/browser/blob/blob_async_builder_host_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/blob/blob_async_transport_request_builder_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/blob/blob_reader_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + storage/browser/blob/blob_storage_context_unittest.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
A + storage/browser/blob/blob_storage_registry_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/blob/blob_url_request_job_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + storage/browser/fileapi/copy_or_move_file_validator_unittest.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + storage/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
A + storage/browser/fileapi/dragged_file_util_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + storage/browser/fileapi/external_mount_points_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/file_system_context_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + storage/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + storage/browser/fileapi/file_system_file_stream_reader_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + storage/browser/fileapi/file_system_operation_impl_unittest.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
A + storage/browser/fileapi/file_system_operation_impl_write_unittest.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
A + storage/browser/fileapi/file_system_operation_runner_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + storage/browser/fileapi/file_system_quota_client_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + storage/browser/fileapi/file_system_url_request_job_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + storage/browser/fileapi/file_system_url_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/file_system_usage_cache_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/file_writer_delegate_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + storage/browser/fileapi/fileapi_test_file_set.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/fileapi_test_file_set.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/fileapi/isolated_context_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/local_file_stream_reader_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/local_file_stream_writer_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/local_file_util_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + storage/browser/fileapi/native_file_util_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/obfuscated_file_util_unittest.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
A + storage/browser/fileapi/plugin_private_file_system_backend_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + storage/browser/fileapi/quota/quota_backend_impl_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/quota/quota_reservation_manager_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/recursive_operation_delegate_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/fileapi/sandbox_directory_database_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + storage/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/fileapi/sandbox_file_system_backend_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/fileapi/sandbox_isolated_origin_database_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/sandbox_origin_database_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/fileapi/sandbox_prioritized_origin_database_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/timed_task_helper_unittest.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/transient_file_util_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/quota/quota_database_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/quota/quota_manager_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + storage/browser/quota/storage_monitor_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + storage/browser/quota/usage_tracker_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/async_file_test_helper.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/async_file_test_helper.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A + storage/browser/test/mock_blob_url_request_context.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_blob_url_request_context.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_file_change_observer.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_file_change_observer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_file_update_observer.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_file_update_observer.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A + storage/browser/test/mock_quota_manager.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_quota_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_quota_manager_proxy.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_quota_manager_proxy.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_quota_manager_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + storage/browser/test/mock_special_storage_policy.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_special_storage_policy.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_storage_client.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_storage_client.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_url_request_delegate.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_url_request_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/sandbox_database_test_helper.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/sandbox_database_test_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/sandbox_file_system_test_helper.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/sandbox_file_system_test_helper.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + storage/browser/test/test_file_system_backend.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/test_file_system_backend.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/test_file_system_context.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/test_file_system_context.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A + storage/browser/test/test_file_system_options.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/test_file_system_options.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (9 generated)
pwnall
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-09-26 17:33:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368913003/1
4 years, 2 months ago (2016-09-26 17:34:00 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-09-26 17:39:30 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/134546) android_clang_dbg_recipe on ...
4 years, 2 months ago (2016-09-26 17:39:31 UTC) #4
pwnall
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-09-26 20:36:54 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368913003/20001
4 years, 2 months ago (2016-09-26 20:37:21 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-09-26 20:50:39 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/267061)
4 years, 2 months ago (2016-09-26 20:50:40 UTC) #8
pwnall
4 years, 2 months ago (2016-09-27 20:18:05 UTC) #9 
Description was changed from

==========
Add storage_unittests target.

The unit tests for storage/browser/ currently live under
content/browser/. This change creates a storage_unittests target, so the
_unittest.cc files can live next to the files that they test.

BUG=
==========

to

==========
Populate storage_unittests target.

The unit tests for storage/browser/ currently live under
content/browser/. This change moves them under the newly
created storage_unittests target, so the _unittest.cc files
can live next to the files that they test.

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698