content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc - Issue 2368913003: Populate storage_unittests target.

Side by Side Diff: content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc

Issue 2368913003: Populate storage_unittests target. (Closed)

Patch Set: Removed unnecessary include from storage/browser/blob/blob_storage_context_unittest.cc. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/fileapi/sandbox_directory_database_unittest.cc ('k') | content/browser/fileapi/sandbox_file_system_backend_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #include "storage/browser/fileapi/sandbox_file_system_backend_delegate.h"

6

7 #include <memory>

8

9 #include "base/files/file_util.h"

10 #include "base/files/scoped_temp_dir.h"

11 #include "base/threading/thread_task_runner_handle.h"

12 #include "content/public/test/test_file_system_options.h"

13 #include "storage/browser/fileapi/file_system_url.h"

14 #include "testing/gtest/include/gtest/gtest.h"

15 #include "url/gurl.h"

16

17 using storage::FileSystemURL;

18

19 namespace content {

20

21 namespace {

22

23 FileSystemURL CreateFileSystemURL(const char* path) {

24 const GURL kOrigin("http://foo/");

25 return storage::FileSystemURL::CreateForTest(

26 kOrigin,

27 storage::kFileSystemTypeTemporary,

28 base::FilePath::FromUTF8Unsafe(path));

29 }

30

31 } // namespace

32

33 class SandboxFileSystemBackendDelegateTest : public testing::Test {

34 protected:

35 void SetUp() override {

36 ASSERT_TRUE(data_dir_.CreateUniqueTempDir());

37 delegate_.reset(new storage::SandboxFileSystemBackendDelegate(

38 NULL /* quota_manager_proxy */,

39 base::ThreadTaskRunnerHandle::Get().get(), data_dir_.GetPath(),

40 NULL /* special_storage_policy */, CreateAllowFileAccessOptions()));

41 }

42

43 bool IsAccessValid(const FileSystemURL& url) const {

44 return delegate_->IsAccessValid(url);

45 }

46

47 base::ScopedTempDir data_dir_;

48 base::MessageLoop message_loop_;

49 std::unique_ptr<storage::SandboxFileSystemBackendDelegate> delegate_;

50 };

51

52 TEST_F(SandboxFileSystemBackendDelegateTest, IsAccessValid) {

53 // Normal case.

54 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("a")));

55

56 // Access to a path with parent references ('..') should be disallowed.

57 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("a/../b")));

58

59 // Access from non-allowed scheme should be disallowed.

60 EXPECT_FALSE(IsAccessValid(

61 FileSystemURL::CreateForTest(GURL("unknown://bar"),

62 storage::kFileSystemTypeTemporary,

63 base::FilePath::FromUTF8Unsafe("foo"))));

64

65 // Access with restricted name should be disallowed.

66 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(".")));

67 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("..")));

68

69 // This is also disallowed due to Windows XP parent path handling.

70 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("...")));

71

72 // These are identified as unsafe cases due to weird path handling

73 // on Windows.

74 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(" ..")));

75 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(".. ")));

76

77 // Similar but safe cases.

78 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(" .")));

79 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(". ")));

80 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("b.")));

81 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(".b")));

82

83 // A path that looks like a drive letter.

84 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("c:")));

85 }

86

87 } // namespace content

OLD	NEW