Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: content/browser/streams/stream_unittest.cc

Issue 2368913002: Fix stream errors that occur after a stream starts not propagating. (Closed)
Patch Set: fix tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/streams/stream_unittest.cc
diff --git a/content/browser/streams/stream_unittest.cc b/content/browser/streams/stream_unittest.cc
index 314f56b714fed169617d2f5b1ed68d770fce2f6d..38f922a648e6ef8960e5fd679e9a1b3ecd269367 100644
--- a/content/browser/streams/stream_unittest.cc
+++ b/content/browser/streams/stream_unittest.cc
@@ -195,7 +195,7 @@ TEST_F(StreamTest, Stream) {
const int kBufferSize = 1000000;
scoped_refptr<net::IOBuffer> buffer(NewIOBuffer(kBufferSize));
writer.Write(stream.get(), buffer, kBufferSize);
- stream->Finalize();
+ stream->Finalize(0);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(reader.completed());
tyoshino (SeeGerritForStatus) 2016/09/27 10:24:56 check status() here and could you please add a te
jam 2016/09/27 15:41:07 Done.
@@ -236,7 +236,7 @@ TEST_F(StreamTest, ClosedReaderDoesNotReturnStreamEmpty) {
const int kBufferSize = 0;
scoped_refptr<net::IOBuffer> buffer(NewIOBuffer(kBufferSize));
stream->AddData(buffer, kBufferSize);
- stream->Finalize();
+ stream->Finalize(0);
tyoshino (SeeGerritForStatus) 2016/09/27 10:24:56 check status() here
jam 2016/09/27 15:41:07 Done.
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(reader.completed());
EXPECT_EQ(0, reader.buffer()->capacity());

Powered by Google App Engine
This is Rietveld 408576698