Fix stream errors that occur after a stream starts not propagating.

content/browser/streams/stream_url_request_job.cc

Index: content/browser/streams/stream_url_request_job.cc
diff --git a/content/browser/streams/stream_url_request_job.cc b/content/browser/streams/stream_url_request_job.cc
index 04a24ebfbbb5880ce58e9c5104378befe100242e..dd6604da31992597b9fe7d716775a8069fe2c6a6 100644
--- a/content/browser/streams/stream_url_request_job.cc
+++ b/content/browser/streams/stream_url_request_job.cc
@@ -30,6 +30,7 @@ StreamURLRequestJob::StreamURLRequestJob(
       total_bytes_read_(0),
       max_range_(0),
       request_failed_(false),
+      error_code_(0),

[tyoshino (SeeGerritForStatus), 2016/09/27 10:24:56]

how about net::OK so that it's clear that it's intended to hold a net error?

[jam, 2016/09/27 15:41:07]

Done.

       weak_factory_(this) {
   DCHECK(stream_.get());
   stream_->SetReadObserver(this);
@@ -92,12 +93,8 @@ void StreamURLRequestJob::Kill() {
 }
 
 int StreamURLRequestJob::ReadRawData(net::IOBuffer* buf, int buf_size) {
-  // TODO(ellyjones): This is not right. The old code returned true here, but
-  // ReadRawData's old contract was to return true only for synchronous
-  // successes, which had the effect of treating all errors as synchronous EOFs.
-  // See https://crbug.com/508957
   if (request_failed_)
-    return 0;
+    return error_code_;
 
   DCHECK(buf);
   int to_read = buf_size;
@@ -112,9 +109,10 @@ int StreamURLRequestJob::ReadRawData(net::IOBuffer* buf, int buf_size) {
   int bytes_read = 0;
   switch (stream_->ReadRawData(buf, to_read, &bytes_read)) {
     case Stream::STREAM_HAS_DATA:
-    case Stream::STREAM_COMPLETE:
       total_bytes_read_ += bytes_read;
       return bytes_read;
+    case Stream::STREAM_COMPLETE:
+      return stream_->GetStatus();
     case Stream::STREAM_EMPTY:
       pending_buffer_ = buf;
       pending_buffer_size_ = to_read;
@@ -169,6 +167,7 @@ void StreamURLRequestJob::DidStart() {
 
 void StreamURLRequestJob::NotifyFailure(int error_code) {
   request_failed_ = true;
+  error_code_ = error_code;
 
   // This method can only be called before headers are set.
   DCHECK(!headers_set_);