Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Unified Diff: components/cronet/android/cronet_url_request_context_adapter.h

Issue 2368663002: change return type of StartNetLogToFile (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_url_request_context_adapter.h
diff --git a/components/cronet/android/cronet_url_request_context_adapter.h b/components/cronet/android/cronet_url_request_context_adapter.h
index 901f26c67c208c70861fb09b9ed5af8716c7c49f..70e9283a47a2192a65e4c7695b5680d27987e403 100644
--- a/components/cronet/android/cronet_url_request_context_adapter.h
+++ b/components/cronet/android/cronet_url_request_context_adapter.h
@@ -80,7 +80,7 @@ class CronetURLRequestContextAdapter
net::URLRequestContext* GetURLRequestContext();
// Starts NetLog logging to file. This can be called on any thread.
xunjieli 2016/09/26 16:35:39 Could you document the return value in the comment
- void StartNetLogToFile(JNIEnv* env,
+ bool StartNetLogToFile(JNIEnv* env,
const base::android::JavaParamRef<jobject>& jcaller,
const base::android::JavaParamRef<jstring>& jfile_name,
jboolean jlog_all);

Powered by Google App Engine
This is Rietveld 408576698