Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2368613002: [modules] Simplify treatment of empty imports. (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Simplify treatment of empty imports. There's no reason (anymore) to have empty imports in special_imports. Remove them from there and rename special_imports to namespace_imports to be more precise. R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/f9e9a016611b3ed2206ff3b025d069dc5108709e Cr-Commit-Position: refs/heads/master@{#39693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -42 lines) Patch
M src/ast/modules.h View 5 chunks +10 lines, -10 lines 0 comments Download
M src/ast/modules.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M src/ast/scopeinfo.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
neis
4 years, 3 months ago (2016-09-23 18:40:08 UTC) #1
adamk
lgtm
4 years, 3 months ago (2016-09-23 18:41:50 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 2362083002 Patch 40001). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-23 18:46:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368613002/1
4 years, 3 months ago (2016-09-23 19:03:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 19:35:51 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 19:36:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9e9a016611b3ed2206ff3b025d069dc5108709e
Cr-Commit-Position: refs/heads/master@{#39693}

Powered by Google App Engine
This is Rietveld 408576698