[modules] Do basic linking.

[modules] Do basic linking.

Resolve imports and indirect exports at instantiation time.

With this CL we have some basic functionality for modules working.  Not yet
supported: star exports, namespace imports, cycle detection, proper variable
initialisation in mutually recursive modules.

BUG=v8:1569
Committed: https://crrev.com/d7858e35f61596a12be8468bd099bfe191a0da99
Cr-Commit-Position: refs/heads/master@{#39689}

[adamk, 2016-09-23 00:39:09]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-09-23 00:39:10]

Mostly looks good. Please add more CL description (especially the tracking bug).

https://codereview.chromium.org/2362083002/diff/1/src/messages.h
File src/messages.h (right):

https://codereview.chromium.org/2362083002/diff/1/src/messages.h#newcode614
src/messages.h:614: T(UnresolvableExport, "Module does not provide an export
named '%'")         \
Can we not provide the module name along with the export name?

https://codereview.chromium.org/2362083002/diff/1/test/mjsunit/modules-FAIL-4.js
File test/mjsunit/modules-FAIL-4.js (right):

https://codereview.chromium.org/2362083002/diff/1/test/mjsunit/modules-FAIL-4...
test/mjsunit/modules-FAIL-4.js:7: import {a as b} from "modules-FAIL-4.js";
Isn't this redundant with FAIL-2?

[adamk, 2016-09-23 00:51:40]

https://codereview.chromium.org/2362083002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2362083002/diff/1/src/objects.cc#newcode19616
src/objects.cc:19616: Object* object = exports->Lookup(name);
Please put this in a handle for consistency.

https://codereview.chromium.org/2362083002/diff/1/src/objects.cc#newcode19617
src/objects.cc:19617: if (!object->IsCell()) UNIMPLEMENTED();
Can you add a comment here explaining what needs to be implemented?

[neis, 2016-09-23 17:40:33]

Addressed comments, added some more tests, and made a few cleanups.

https://codereview.chromium.org/2362083002/diff/1/src/messages.h
File src/messages.h (right):

https://codereview.chromium.org/2362083002/diff/1/src/messages.h#newcode614
src/messages.h:614: T(UnresolvableExport, "Module does not provide an export
named '%'")         \
On 2016/09/23 00:39:10, adamk wrote:
> Can we not provide the module name along with the export name?

Not without extra work. As discussed offline, we'll have to revisit error
reporting anyways.

https://codereview.chromium.org/2362083002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2362083002/diff/1/src/objects.cc#newcode19616
src/objects.cc:19616: Object* object = exports->Lookup(name);
On 2016/09/23 00:51:40, adamk wrote:
> Please put this in a handle for consistency.

Done.

https://codereview.chromium.org/2362083002/diff/1/src/objects.cc#newcode19617
src/objects.cc:19617: if (!object->IsCell()) UNIMPLEMENTED();
On 2016/09/23 00:51:40, adamk wrote:
> Can you add a comment here explaining what needs to be implemented?

Done.

https://codereview.chromium.org/2362083002/diff/1/test/mjsunit/modules-FAIL-4.js
File test/mjsunit/modules-FAIL-4.js (right):

https://codereview.chromium.org/2362083002/diff/1/test/mjsunit/modules-FAIL-4...
test/mjsunit/modules-FAIL-4.js:7: import {a as b} from "modules-FAIL-4.js";
On 2016/09/23 00:39:10, adamk wrote:
> Isn't this redundant with FAIL-2?

Not at all. This one here involves an indirect export.

[neis, 2016-09-23 18:14:23]

Description was changed from

==========
[modules] Do basic linking.

BUG=
==========

to

==========
[modules] Do basic linking.

Resolve imports and indirect exports at instantiation time.

With this CL we have some basic functionality for modules working.  Not yet
supported: star exports, namespace imports, cycle detection, proper variable
initialisation in mutually recursive modules.

BUG=v8:1569
==========

[neis, 2016-09-23 18:21:32]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 18:21:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-09-23 18:22:49]

lgtm

[commit-bot: I haz the power, 2016-09-23 18:58:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 18:59:00]

Dry run: This issue passed the CQ dry run.

[neis, 2016-09-23 18:59:18]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-09-23 18:59:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 19:02:37]

Description was changed from

==========
[modules] Do basic linking.

Resolve imports and indirect exports at instantiation time.

With this CL we have some basic functionality for modules working.  Not yet
supported: star exports, namespace imports, cycle detection, proper variable
initialisation in mutually recursive modules.

BUG=v8:1569
==========

to

==========
[modules] Do basic linking.

Resolve imports and indirect exports at instantiation time.

With this CL we have some basic functionality for modules working.  Not yet
supported: star exports, namespace imports, cycle detection, proper variable
initialisation in mutually recursive modules.

BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-09-23 19:02:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-23 19:03:12]

Description was changed from

==========
[modules] Do basic linking.

Resolve imports and indirect exports at instantiation time.

With this CL we have some basic functionality for modules working.  Not yet
supported: star exports, namespace imports, cycle detection, proper variable
initialisation in mutually recursive modules.

BUG=v8:1569
==========

to

==========
[modules] Do basic linking.

Resolve imports and indirect exports at instantiation time.

With this CL we have some basic functionality for modules working.  Not yet
supported: star exports, namespace imports, cycle detection, proper variable
initialisation in mutually recursive modules.

BUG=v8:1569

Committed: https://crrev.com/d7858e35f61596a12be8468bd099bfe191a0da99
Cr-Commit-Position: refs/heads/master@{#39689}
==========

[commit-bot: I haz the power, 2016-09-23 19:03:13]

Patchset 3 (id:??) landed as
https://crrev.com/d7858e35f61596a12be8468bd099bfe191a0da99
Cr-Commit-Position: refs/heads/master@{#39689}