Issue 23686003: Add alignment checks to typed_data views

Issue 23686003: Add alignment checks to typed_data views (Closed)

Created:
7 years, 3 months ago by Cutch

Modified:
7 years, 3 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add alignment checks to typed_data views R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=27278

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -0 lines)			Patch
	M	runtime/lib/typed_data.dart	View	1	10 chunks	+17 lines, -0 lines	0 comments	Download
	M	tests/co19/co19-runtime.status	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM after alignment check of int8, uint8 and uint8clamped is removed. https://codereview.chromium.org/23686003/diff/1/runtime/lib/typed_data.dart File runtime/lib/typed_data.dart (right): ...

7 years, 3 months ago (2013-08-29 16:30:15 UTC) #2

Cutch

https://codereview.chromium.org/23686003/diff/1/runtime/lib/typed_data.dart File runtime/lib/typed_data.dart (right): https://codereview.chromium.org/23686003/diff/1/runtime/lib/typed_data.dart#newcode2184 runtime/lib/typed_data.dart:2184: _offsetAlignmentCheck(_offsetInBytes, Int8List.BYTES_PER_ELEMENT); On 2013/08/29 16:30:16, siva wrote: > int8, ...

7 years, 3 months ago (2013-09-08 13:16:36 UTC) #3

Cutch

7 years, 3 months ago (2013-09-08 15:18:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r27278 (presubmit successful).

Expand Messages | Collapse Messages