Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm

Issue 2368593002: Prevent interpretating userinfo as url scheme when editing bookmarks (Closed)
Patch Set: Fix unittest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm
index 5a9a0958c52554298774c4ca35ba2172dcb54f25..efaa16e1ddd12c21beeb44acc4136ed25b9ef4fc 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm
@@ -259,6 +259,48 @@ TEST_F(BookmarkEditorControllerUtf8NodeTest, DisplayUtf8Name) {
[controller_ cancel:nil];
}
+class BookmarkEditorControllerEditKeepsSchemeTest : public CocoaProfileTest {
sky 2016/09/26 23:03:02 I wouldn't bother with a separate test facade and
elawrence 2016/09/29 21:53:03 Done.
+ public:
+ BookmarkEditorController* controller_;
+
+ void SetUp() override {
+ CocoaProfileTest::SetUp();
+ ASSERT_TRUE(profile());
+
+ BookmarkModel* model =
+ BookmarkModelFactory::GetForBrowserContext(profile());
+ const BookmarkNode* parent = model->bookmark_bar_node();
+ base::string16 title = ASCIIToUTF16("UserInfo");
+ const char* url_name = "http://javascript:scripttext@example.com/";
+ const BookmarkNode* node = model->AddURL(parent, 0, title, GURL(url_name));
+ controller_ = [[BookmarkEditorController alloc]
+ initWithParentWindow:test_window()
+ profile:profile()
+ parent:parent
+ node:node
+ url:GURL()
+ title:base::string16()
+ configuration:BookmarkEditor::SHOW_TREE];
+
+ [controller_ runAsModalSheet];
+ }
+
+ void TearDown() override {
+ controller_ = NULL;
+ CocoaProfileTest::TearDown();
+ }
+};
+
+TEST_F(BookmarkEditorControllerEditKeepsSchemeTest, EditKeepsScheme) {
+ // Do not elide "http://" prefix when userinfo is present, elide only
+ // the trailing slash
+ EXPECT_NSEQ(
+ [NSString stringWithCString:"http://javascript:scripttext@example.com"
+ encoding:NSUTF8StringEncoding],
+ [controller_ displayURL]);
+ [controller_ cancel:nil];
+}
+
class BookmarkEditorControllerTreeTest : public CocoaProfileTest {
public:

Powered by Google App Engine
This is Rietveld 408576698