Prevent interpretating userinfo as url scheme when editing bookmarks

chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/strings/string16.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
@@ skipping 241 matching lines @@
 };
 
 TEST_F(BookmarkEditorControllerUtf8NodeTest, DisplayUtf8Name) {
   // The "http://" prefix is trimmed, but the UTF-8 formatted characters remain.
   EXPECT_NSEQ([NSString stringWithCString:"www.foobar.com/心得寫作"
                                  encoding:NSUTF8StringEncoding],
               [controller_ displayURL]);
   [controller_ cancel:nil];
 }
 
+class BookmarkEditorControllerEditKeepsSchemeTest : public CocoaProfileTest {

[sky, 2016/09/26 23:03:02]

I wouldn't bother with a separate test facade and just use TEST() for this. The
separate facade is nice if you're going to do more than one test that wants this
setup, but that doesn't seem to be the case (doing that also means you'll fix
controller_ not being initialiazed and controller_ should be protected in style
guide).

[elawrence, 2016/09/29 21:53:03]

Done.

+ public:
+  BookmarkEditorController* controller_;
+
+  void SetUp() override {
+    CocoaProfileTest::SetUp();
+    ASSERT_TRUE(profile());
+
+    BookmarkModel* model =
+        BookmarkModelFactory::GetForBrowserContext(profile());
+    const BookmarkNode* parent = model->bookmark_bar_node();
+    base::string16 title = ASCIIToUTF16("UserInfo");
+    const char* url_name = "http://javascript:scripttext@example.com/";
+    const BookmarkNode* node = model->AddURL(parent, 0, title, GURL(url_name));
+    controller_ = [[BookmarkEditorController alloc]
+        initWithParentWindow:test_window()
+                     profile:profile()
+                      parent:parent
+                        node:node
+                         url:GURL()
+                       title:base::string16()
+               configuration:BookmarkEditor::SHOW_TREE];
+
+    [controller_ runAsModalSheet];
+  }
+
+  void TearDown() override {
+    controller_ = NULL;
+    CocoaProfileTest::TearDown();
+  }
+};
+
+TEST_F(BookmarkEditorControllerEditKeepsSchemeTest, EditKeepsScheme) {
+  // Do not elide "http://" prefix when userinfo is present, elide only
+  // the trailing slash
+  EXPECT_NSEQ(
+      [NSString stringWithCString:"http://javascript:scripttext@example.com"
+                         encoding:NSUTF8StringEncoding],
+      [controller_ displayURL]);
+  [controller_ cancel:nil];
+}
+
 class BookmarkEditorControllerTreeTest : public CocoaProfileTest {
 
  public:
   BookmarkEditorController* controller_;
   const BookmarkNode* folder_a_;
   const BookmarkNode* folder_b_;
   const BookmarkNode* folder_bb_;
   const BookmarkNode* folder_c_;
   const BookmarkNode* bookmark_bb_3_;
   GURL bb3_url_1_;
@@ skipping 208 matching lines @@
 
 TEST_F(BookmarkEditorControllerTreeNoNodeTest, NewBookmarkNoNode) {
   [controller_ setDisplayName:@"NEW BOOKMARK"];
   [controller_ setDisplayURL:@"http://NEWURL.com"];
   [controller_ ok:nil];
   const BookmarkNode* new_node = folder_bb_->GetChild(5);
   ASSERT_EQ(0, new_node->child_count());
   EXPECT_EQ(new_node->GetTitle(), ASCIIToUTF16("NEW BOOKMARK"));
   EXPECT_EQ(new_node->url(), GURL("http://NEWURL.com"));
 }