Prevent interpretating userinfo as url scheme when editing bookmarks

chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm
index 5a9a0958c52554298774c4ca35ba2172dcb54f25..efaa16e1ddd12c21beeb44acc4136ed25b9ef4fc 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm
@@ -259,6 +259,48 @@ TEST_F(BookmarkEditorControllerUtf8NodeTest, DisplayUtf8Name) {
   [controller_ cancel:nil];
 }
 
+class BookmarkEditorControllerEditKeepsSchemeTest : public CocoaProfileTest {

[sky, 2016/09/26 23:03:02]

I wouldn't bother with a separate test facade and just use TEST() for this. The
separate facade is nice if you're going to do more than one test that wants this
setup, but that doesn't seem to be the case (doing that also means you'll fix
controller_ not being initialiazed and controller_ should be protected in style
guide).

[elawrence, 2016/09/29 21:53:03]

Done.

+ public:
+  BookmarkEditorController* controller_;
+
+  void SetUp() override {
+    CocoaProfileTest::SetUp();
+    ASSERT_TRUE(profile());
+
+    BookmarkModel* model =
+        BookmarkModelFactory::GetForBrowserContext(profile());
+    const BookmarkNode* parent = model->bookmark_bar_node();
+    base::string16 title = ASCIIToUTF16("UserInfo");
+    const char* url_name = "http://javascript:scripttext@example.com/";
+    const BookmarkNode* node = model->AddURL(parent, 0, title, GURL(url_name));
+    controller_ = [[BookmarkEditorController alloc]
+        initWithParentWindow:test_window()
+                     profile:profile()
+                      parent:parent
+                        node:node
+                         url:GURL()
+                       title:base::string16()
+               configuration:BookmarkEditor::SHOW_TREE];
+
+    [controller_ runAsModalSheet];
+  }
+
+  void TearDown() override {
+    controller_ = NULL;
+    CocoaProfileTest::TearDown();
+  }
+};
+
+TEST_F(BookmarkEditorControllerEditKeepsSchemeTest, EditKeepsScheme) {
+  // Do not elide "http://" prefix when userinfo is present, elide only
+  // the trailing slash
+  EXPECT_NSEQ(
+      [NSString stringWithCString:"http://javascript:scripttext@example.com"
+                         encoding:NSUTF8StringEncoding],
+      [controller_ displayURL]);
+  [controller_ cancel:nil];
+}
+
 class BookmarkEditorControllerTreeTest : public CocoaProfileTest {
 
  public: